Add Text custom attribute support - #895
Conversation
🤖 Augment PR SummarySummary: This PR wires up initial support for attaching/querying custom text attributes and introduces a marker type for superscript. Changes:
Technical Notes: Attribute transfer from 🤖 Was this summary useful? React with 👍 or 👎 |
| attributes.append(TextAttributeModifier(value: value)) | ||
| } | ||
|
|
||
| public subscript<T>(_ key: T.Type) -> T? where T: TextAttribute { |
There was a problem hiding this comment.
The doc comment on customAttribute says “Only one attribute of each type … with inner attributes taking precedence”, but CustomAttributes.subscript returns the first match in attributes order and add/modify only append; if multiple values of the same TextAttribute type are present this will likely return the outer/earlier one instead of the inner/later one.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
==========================================
+ Coverage 26.68% 26.71% +0.02%
==========================================
Files 694 697 +3
Lines 48683 48907 +224
==========================================
+ Hits 12993 13065 +72
- Misses 35690 35842 +152 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Agent Summary
Text.SuperscriptandText.CustomAttributessupport