Fix support framework linkage for binary consumers - #959
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
==========================================
- Coverage 26.78% 26.78% -0.01%
==========================================
Files 732 732
Lines 52771 52771
==========================================
- Hits 14136 14135 -1
- Misses 38635 38636 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
👀 Human Input Needed → Pair Review Briefing |
🤖 Augment PR SummarySummary: Fixes binary-consumer linkage by making Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| if [ "${OPENSWIFTUI_USE_LOCAL_DEPS:-0}" = "1" ]; then | ||
| echo "$local_project" | ||
| else |
There was a problem hiding this comment.
dependency_project_path echoes local_project unconditionally when OPENSWIFTUI_USE_LOCAL_DEPS=1; if the local checkout path is missing, the resulting xcodebuild failure can be hard to diagnose. Consider validating that the path exists (or emitting a targeted error) before returning it.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Summary
Motivation
Binary SwiftPM consumers could load duplicate support types or fail to locate runtime framework dependencies, preventing application and Preview hosts from launching. This keeps static AttributeGraph support owned by OpenSwiftUICore while distributing the remaining runtime support frameworks explicitly.
Validation