Use the OpenSwiftUI ABI namespace for OpenSwiftUICore - #960
Merged
Conversation
Use the OpenSwiftUICore declarations for shared event, style context, and view debug types so the modules can safely share an ABI namespace.
Kyle-Ye
marked this pull request as ready for review
August 1, 2026 07:50
🤖 Augment PR SummarySummary: Align OpenSwiftUICore’s emitted symbols with the OpenSwiftUI ABI namespace so binary consumers resolve core symbols consistently (e.g., Xcode Previews). Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
|
👀 Human Input Needed → Pair Review Briefing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
===========================================
+ Coverage 14.57% 26.79% +12.21%
===========================================
Files 689 730 +41
Lines 46143 52761 +6618
===========================================
+ Hits 6725 14135 +7410
+ Misses 39418 38626 -792 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Kyle-Ye
force-pushed
the
feature/abi-name
branch
from
August 1, 2026 08:49
ea1321d to
77f0d70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
OpenSwiftUI and OpenSwiftUICore are distributed together as one API surface. Binary consumers, including Xcode previews, need core symbols to resolve through the same OpenSwiftUI namespace exposed by the public module.
The core target previously emitted OpenSwiftUICore-prefixed symbols while binary consumers resolved them through OpenSwiftUI. Aligning the ABI name keeps source and binary distributions consistent and prevents preview loading failures caused by the mismatched symbol namespace.
Validation