Skip to content

Implement ViewTransform coordinate-space conversions - #963

Merged
Kyle-Ye merged 11 commits into
mainfrom
bugfix/view_transform
Aug 2, 2026
Merged

Implement ViewTransform coordinate-space conversions#963
Kyle-Ye merged 11 commits into
mainfrom
bugfix/view_transform

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • complete ViewTransform storage, traversal, and coordinate-space conversion behavior
  • apply transforms to geometry and scroll-view clipping queries
  • update coordinate-space support and add focused ViewTransform coverage

Testing

  • ViewTransformTests pass on macOS and Linux

@github-actions github-actions Bot added area: layout Layout, geometry, safe area, alignment, stacks, or sizing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability. labels Aug 2, 2026
@Kyle-Ye
Kyle-Ye marked this pull request as ready for review August 2, 2026 06:45
@Kyle-Ye
Kyle-Ye merged commit 1ed914d into main Aug 2, 2026
4 of 8 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/view_transform branch August 2, 2026 06:46
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.60349% with 166 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.18%. Comparing base (b57a145) to head (174d81c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/OpenSwiftUICore/Layout/View/ViewTransform.swift 63.34% 136 Missing ⚠️
...Layout/CoordinateSpace/ScrollCoordinateSpace.swift 0.00% 25 Missing ⚠️
Sources/OpenSwiftUICore/Shape/Path.swift 0.00% 4 Missing ⚠️
...enSwiftUICore/Layout/Geometry/GeometryReader.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   26.70%   27.18%   +0.48%     
==========================================
  Files         730      730              
  Lines       52920    53093     +173     
==========================================
+ Hits        14133    14435     +302     
+ Misses      38787    38658     -129     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: layout Layout, geometry, safe area, alignment, stacks, or sizing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant