Skip to content

Fix safe area inset resolution across coordinate spaces - #965

Merged
Kyle-Ye merged 3 commits into
mainfrom
bugfix/view_transform
Aug 2, 2026
Merged

Fix safe area inset resolution across coordinate spaces#965
Kyle-Ye merged 3 commits into
mainfrom
bugfix/view_transform

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Convert safe-area boundaries into the local coordinate space before resolving insets.
  • Fix corner-point rectangle construction for non-zero-based ArraySlice values.

Fixes #964.

@Kyle-Ye
Kyle-Ye marked this pull request as ready for review August 2, 2026 08:59
@github-actions github-actions Bot added area: layout Layout, geometry, safe area, alignment, stacks, or sizing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly. labels Aug 2, 2026
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.77193% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.14%. Comparing base (1ed914d) to head (b55310d).

Files with missing lines Patch % Lines
...ources/OpenSwiftUICore/Layout/SafeAreaInsets.swift 0.00% 52 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
+ Coverage   15.12%   15.14%   +0.01%     
==========================================
  Files         687      687              
  Lines       46487    46528      +41     
==========================================
+ Hits         7033     7046      +13     
- Misses      39454    39482      +28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 9ae9fec into main Aug 2, 2026
3 of 9 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/view_transform branch August 2, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: layout Layout, geometry, safe area, alignment, stacks, or sizing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safe-area adjustment incorrectly expands a centered Text background

1 participant