Skip to content

Fix preference bridge ownership and align preference internals - #966

Merged
Kyle-Ye merged 2 commits into
mainfrom
optimize/typename
Aug 2, 2026
Merged

Fix preference bridge ownership and align preference internals#966
Kyle-Ye merged 2 commits into
mainfrom
optimize/typename

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Borrow unmanaged ViewGraph children without consuming ownership during preference bridge updates
  • Align preference modifier isolation and preference API signatures
  • Rename PreferencesAggregator to PreferenceAggregator
  • Improve unqualified type-name handling and simplify decoder identifiers
  • Correct minor internal metadata typos

@Kyle-Ye
Kyle-Ye marked this pull request as ready for review August 2, 2026 10:05
@github-actions github-actions Bot added area: data-flow State, binding, environment, preference, observation, or property data flow. type: maintenance Refactor, cleanup, dependency bump, NFC, or internal maintenance. labels Aug 2, 2026
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.30%. Comparing base (1ed914d) to head (541f4ed).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...SwiftUICore/Data/Preference/PreferenceBridge.swift 0.00% 4 Missing ⚠️
...penSwiftUICore/Data/Preference/PreferenceKey.swift 50.00% 1 Missing ⚠️
...re/Data/Preference/PreferenceWritingModifier.swift 0.00% 1 Missing ⚠️
...s/OpenSwiftUICore/Render/PlatformViewFactory.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #966       +/-   ##
===========================================
+ Coverage   15.12%   27.30%   +12.17%     
===========================================
  Files         687      730       +43     
  Lines       46487    53134     +6647     
===========================================
+ Hits         7033    14509     +7476     
+ Misses      39454    38625      -829     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Kyle-Ye commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

/uitest update

@tuist

tuist Bot commented Aug 2, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1004 0 1004 e5a72add1

Failed Tests ❌

Showing 5 of 6 failed tests. See links above for full details.

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 1m 17s e5a72add1

@Kyle-Ye
Kyle-Ye merged commit 252f0fc into main Aug 2, 2026
10 of 13 checks passed
@Kyle-Ye
Kyle-Ye deleted the optimize/typename branch August 2, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: data-flow State, binding, environment, preference, observation, or property data flow. type: maintenance Refactor, cleanup, dependency bump, NFC, or internal maintenance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant