Skip to content

Add full DisplayListPrinter support - #970

Merged
Kyle-Ye merged 5 commits into
mainfrom
feature/text_dl
Aug 2, 2026
Merged

Add full DisplayListPrinter support#970
Kyle-Ye merged 5 commits into
mainfrom
feature/text_dl

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Add full and minimal S-expression descriptions for display lists, items, content, effects, and graphics filters
  • Add shader option and resolved-shader storage needed to describe shader filters
  • Add SExpPrintable with a shared description implementation
  • Add symbol-dual coverage for display-list output, including shader filter payloads, alongside focused SExpPrintable coverage

@github-actions github-actions Bot added area: graphics Color, shape, gradient, image, symbols, and graphics primitives. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability. type: tests Test coverage, test infrastructure, snapshots, or test-only changes. labels Aug 2, 2026
@Kyle-Ye
Kyle-Ye marked this pull request as ready for review August 2, 2026 16:55
@Kyle-Ye Kyle-Ye changed the title Complete DisplayList S-expression printing Add full DisplayListPrinter support Aug 2, 2026
@Kyle-Ye
Kyle-Ye merged commit 2bb6cfb into main Aug 2, 2026
1 of 8 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/text_dl branch August 2, 2026 16:56
@tuist

tuist Bot commented Aug 2, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1003 0 1003 51d6c9a78

Failed Tests ❌

  • OpenSwiftUI: 13 failed tests (View all)

  • idViewDisplayList() · OpenSwiftUICoreTests · IDViewTests
    (displayList.description → "(display-list (item #:identity 15 #:version 29 (frame (0.0 0.0; 100.0 100.0)) (effect #:opacity 1.0 (item #:identity…

  • nestedUnaryViewRoot() · OpenSwiftUICoreTests · VariadicViewTests
    (displayList.description → "(display-list (item #:identity 8 #:version 25 (frame (0.0 0.0; 100.0 100.0)) (effect #:opacity 1.0 (item #:identity …

  • optionalViewAliasConsumerTracksPresentAndNilSource() · OpenSwiftUITests · ViewAliasTests
    (presentDisplayList → "(display-list (item #:identity 8 #:version 15 (frame (0.0 0.0; 100.0 100.0)) (effect #:opacity 1.0 (item #:identity 7 #:v…

  • viewListUsageRendersStaticAndOptionalAliasSources() · OpenSwiftUITests · ViewAliasTests
    (optionalPresentDisplayList → "(display-list (item #:identity 4 #:version 8 (frame (0.0 0.0; 100.0 100.0)) (effect #:opacity 1.0 (item #:identit…

  • textSpacingWithVerticalWritingModeUsesSideEdges() · OpenSwiftUICoreTests · TextSpacingTests
    (value → -15.0).isApproximatelyEqual(to: expected → -12.0)

Showing 5 of 13 failed tests. See links above for full details.

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 1m 11s 51d6c9a78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Color, shape, gradient, image, symbols, and graphics primitives. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability. type: tests Test coverage, test infrastructure, snapshots, or test-only changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant