Skip to content

Add text orphan and push-out UI test - #973

Merged
Kyle-Ye merged 1 commit into
mainfrom
codex/text-orphan-push-out-example
Aug 2, 2026
Merged

Add text orphan and push-out UI test#973
Kyle-Ye merged 1 commit into
mainfrom
codex/text-orphan-push-out-example

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a shared text example comparing default, enabled, and disabled orphan handling.
  • Expose View.avoidsOrphans(_:) through the SwiftUI SPI interface used by the comparison target.
  • Add snapshot UI coverage for the text orphan and paragraph push-out behavior.

Impact

The UI test now captures how short final lines are handled consistently across both renderers.

Validation

Source diff validation passed.

@github-actions github-actions Bot added area: example Example apps, previews, sample projects, screenshots, or demo assets. area: text Text, labels, line style, and text rendering APIs. type: feature New API, behavior, platform support, or user-facing capability. labels Aug 2, 2026
@Kyle-Ye
Kyle-Ye marked this pull request as ready for review August 2, 2026 18:37
@Kyle-Ye
Kyle-Ye force-pushed the codex/text-orphan-push-out-example branch from 13e4781 to 8f0dd57 Compare August 2, 2026 18:37
@Kyle-Ye Kyle-Ye changed the title Add text orphan and push-out example Add text orphan and push-out UI test Aug 2, 2026
@Kyle-Ye
Kyle-Ye marked this pull request as draft August 2, 2026 18:38
@github-actions github-actions Bot added area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: tests Test coverage, test infrastructure, snapshots, or test-only changes. labels Aug 2, 2026
@Kyle-Ye
Kyle-Ye marked this pull request as ready for review August 2, 2026 18:39
@Kyle-Ye
Kyle-Ye merged commit 55c2938 into main Aug 2, 2026
1 of 8 checks passed
@Kyle-Ye
Kyle-Ye deleted the codex/text-orphan-push-out-example branch August 2, 2026 18:39
@tuist

tuist Bot commented Aug 2, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1003 0 1003 22f25bd4e

Failed Tests ❌

  • OpenSwiftUI: 13 failed tests (View all)

  • metricsOfWrappedLines() · OpenSwiftUICoreTests · MetricsTests
    (result.size.height → 74.0).isApproximatelyEqual(to: FixedFontMetrics.lineHeight * 4 → 64.0)

  • metricsRespectsLineLimit() · OpenSwiftUICoreTests · MetricsTests
    (limited.size.height → 37.0).isApproximatelyEqual(to: FixedFontMetrics.lineHeight * 2 → 32.0)

  • optionalViewAliasConsumerTracksPresentAndNilSource() · OpenSwiftUITests · ViewAliasTests
    (nilDisplayList → "(display-list (item #:identity 8 #:version 15 (frame (0.0 0.0; 100.0 100.0)) (effect #:opacity 1.0 (item #:identity 7 #:versi…

  • optionalViewAliasUsage(sourceIsPresent:) · OpenSwiftUITests · ViewAliasTests
    (displayList → "(display-list (item #:identity 12 #:version 22 (frame (0.0 0.0; 100.0 100.0)) (effect #:opacity 1.0 (item #:identity 11 #:versio…

  • optionalViewAliasDynamicProperty() · OpenSwiftUITests · ViewAliasTests
    (displayList → "(display-list (item #:identity 10 #:version 19 (frame (0.0 0.0; 100.0 100.0)) (effect #:opacity 1.0 (item #:identity 9 #:version…

Showing 5 of 13 failed tests. See links above for full details.

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 1m 34s 22f25bd4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: example Example apps, previews, sample projects, screenshots, or demo assets. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. area: text Text, labels, line style, and text rendering APIs. type: feature New API, behavior, platform support, or user-facing capability. type: tests Test coverage, test infrastructure, snapshots, or test-only changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant