fix(ai): remove setCurrentFrame from ImageSlider unmount cleanup - #2550
Merged
Aias00 merged 5 commits intoAug 28, 2026
Merged
Conversation
…erMind#2541) The unmount cleanup called setCurrentFrame(0), triggering a React state update on an unmounted component. The reset is unnecessary since the component is about to disappear. Remove it; keep clearInterval and isPlaying.current = false. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: liuhy <liuhongyu@apache.org>
auenger
approved these changes
Aug 27, 2026
auenger
left a comment
auenger
left a comment
Contributor
There was a problem hiding this comment.
已完成独立代码审查。该 PR 仅移除组件卸载 cleanup 中的 setCurrentFrame(0)，保留 interval 清理与播放状态复位；重新挂载仍由 useState(0) 初始化。未发现阻塞问题，当前 CI 全绿。PR 目前落后于 main，合并前请按仓库策略同步并重跑 CI。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The unmount cleanup called
setCurrentFrame(0), triggering a React state update on an unmounted component.Location
src/blocks/AI/components/AIButton/ImageSlider.tsx:79Fix
Remove
setCurrentFrame(0)from the cleanup; keepclearIntervalandisPlaying.current = false.Fixes #2541
🤖 Generated with Claude Code