feat(mysql): invisible column management for MySQL 8.0.23+ - #2607
Merged
openai0229 merged 12 commits intoSep 2, 2026
Merged
Conversation
Contributor
|
Follow-up review: changes requested before merge. P1: the column metadata path calls |
Add `visible` field to TableColumn domain model, detect "INVISIBLE" from the EXTRA column in information_schema, and generate the INVISIBLE keyword in column DDL via MysqlColumnTypeEnum. Frontend: add a "Visible" column to the column editor with a VISIBLE/INVISIBLE toggle, gated to MySQL only. Test fixtures: init.sql, grants.sql, cleanup.sql, README.md under script/test-fixtures/mysql/MYSQL-OBJ-003/. Closes OtterMind#2571
Replace hardcoded INVISIBLE string with SQL_INVISIBLE constant from MysqlMetaDataConstants in MysqlColumnTypeEnum.
MySQL column grammar requires VISIBLE/INVISIBLE before the COMMENT clause; the previous order produced ERROR 1064 for invisible columns that carry a comment.
Aias00
force-pushed
the
feature/mysql-invisible-column-2571
branch
from
August 21, 2026 09:39
ee107fa to
4c6521a
Compare
Signed-off-by: liuhy <liuhongyu@apache.org>
Signed-off-by: liuhy <liuhongyu@apache.org>
Signed-off-by: liuhy <liuhongyu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visiblefield toTableColumndomain model and detect"INVISIBLE"from theEXTRAcolumn ininformation_schema.columnsINVISIBLEkeyword in column DDL viaMysqlColumnTypeEnum.buildCreateColumnSql()Closes #2571
Test plan
MODIFY COLUMN ... VISIBLEINVISIBLESELECT *omits invisible columns (explain in UI tooltip)mvn -B compilepasses for the MySQL plugin moduleeslintpasses with zero warnings