fix(tools): harden asynchronous JDBC downloads - #2687
Conversation
f9b8490 to
f4e2c03
Compare
f4e2c03 to
7d28b09
Compare
openai0229
left a comment
There was a problem hiding this comment.
The daemon dispatcher and unique temporary-file plus atomic publish flow fix both reported failure modes, including cleanup after interrupted writes. Approved.\n\nNon-blocking follow-up: the response stream still has no maximum byte limit, so a future hardening change should cap driver downloads and delete the temporary file on overflow. Merge this before #2695, then rebase #2695 so its configured-URL changes retain this atomic-write behavior.
Superseded by a corrected review because shell quoting corrupted the submitted text.
openai0229
left a comment
There was a problem hiding this comment.
The daemon dispatcher and unique temporary-file plus atomic publish flow fix both reported failure modes, including cleanup after interrupted writes. Approved.
Non-blocking follow-up: the response stream still has no maximum byte limit, so a future hardening change should cap driver downloads and delete the temporary file on overflow. Merge this before #2695, then rebase #2695 so its configured-URL changes retain this atomic-write behavior.
7d28b09 to
61f6bf9
Compare
61f6bf9 to
31b6482
Compare
Summary
Validation
Fixes #2684
Latest-main verification (2026-09-04)
144a04ee2; full tools suite passed (73 tests).n- The Linux CI-only race was traced to OkHttp temporarily renaming a daemon worker during its callback. The test now separates stable factory naming from actual callback daemon status; the focused suite passed 10 consecutive runs before the full suite.n- Combined with fix(jdbc): use configured driver download URLs #2695 using a semantic conflict resolution; full combined tools suite passed (76 tests), covering daemon workers, atomic publication, and dynamic runtime paths.