fix(result): stabilize sorting and edit actions - #2868
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - direct regression fix requested and verified locally.
Summary
ORDER BYclause.Cmd/Ctrl+Sto result submission while focus is inside the result set, without triggering console save.Affected surfaces
Verification
yarn install --frozen-lockfile- passed.yarn lint- passed with zero warnings.yarn test:result-set-ui- 38 tests passed.yarn test:shortcut- passed.yarn build:web:community --app_version=0.0.0- passed, including all Community prebuild tests and production bundle verification.mvn -B -f chat2db-community-server/pom.xml -pl :chat2db-community-web -am -Dmaven.test.skip=false -DskipTests=false -Dtest=DmlExecutionRequestValidationTest -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.test.failure.ignore=false test- 7 tests passed, zero failures/errors.mvn -B clean package -Dmaven.test.skip=true -Dchat2db.finalName=chat2db-community -f chat2db-community-server/pom.xml -pl chat2db-community-start -am- passed; tests were explicitly skipped in this package command.ORDER BYclause.short-fourafter editing it toshort-.Cmd+Sproduced oneget_update_sqlrequest and no console-save dialog; the final write endpoint was blocked during this verification.Risk and compatibility
consoleIdis now optional only on select-result update/copy SQL generation requests; datasource and operation validation remain unchanged. No storage schema changes.Reviewer map
ResultSet/index.tsx,ResultSetTable/index.tsx,ScreeningResult/index.tsx, andviewTablePagingModel.ts.Cmd/Ctrl+Sopens console save.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, review, regression tests, and local verification. All reported commands and manual checks were executed against the Community repository.