Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue or PR was found for the delayed dashboard mutation race.
Summary
Dashboard mutations committed against whatever dashboard happened to be active when their promises resolved. A delayed save for dashboard A could replace newly selected dashboard B, while a delayed chart deletion could remove the chart from B and persist the wrong dashboard. This change keeps saves scoped to their dashboard ID, captures chart-deletion ownership before awaiting the API, updates the owning list entry, and leaves a different active dashboard/settings panel untouched.
Affected surfaces
Verification
Risk and compatibility
No API or persisted-data format changes. Updates for the active dashboard retain the existing merge behavior. When another dashboard is active, only the owning dashboard-list entry changes. Chart deletion still persists the original dashboard's filtered chart IDs/schema.
Reviewer map
dashboardMutation.ts, thencreateCommonAction.updateDashboardanddeleteChart.b0d6cd3451d1dd3fe5ac928150850d0ae0a95258; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, tests, Playwright verification, and adversarial review.