fix(ci): preserve quoted Windows signing commands - #2918
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — maintainer-requested recovery of Community Windows Beta packaging.
Summary
Windows signing fails before SSH authentication because PowerShell native argument quoting makes WinSCP parse the session URL as a host named
\scp. Pass the command batch through a UTF-8 BOM script file so URL, host-key and filesystem-path quotes reach WinSCP intact. Remove the temporary command file infinally, and retain the existing Authenticode validation before replacing the original installer.Add regression coverage for MSI and EXE, escaped URL credentials, Unicode paths, failed transfers, invalid signatures, and temporary-file cleanup. Windows CI also runs the actual WinSCP client against a temporary loopback TCP listener to verify URL parsing without signing credentials or an external server.
Affected surfaces
Verification
pwsh -NoLogo -NoProfile -File script/package/tests/windows-signing-test.ps1passed locally. The test fails against the previous/commandimplementation..github/workflows/ci.ymlandgit diff --checkpassed.Host "\scp" does not existafter all six signing secrets were supplied. This patch does not claim a successful signed installer until the updated packaging workflow runs.Risk and compatibility
Reviewer map
script/package/sign_windows_package.ps1; thenscript/package/tests/windows-signing-test.ps1and the Windows CI step.Contributor declaration
AI assistance: implementation and verification performed with Codex.