Skip to content

fix: add zh-CN mapping for Qwen-MT translator #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Morningstar202604 wants to merge 1 commit into from
Closed

fix: add zh-CN mapping for Qwen-MT translator #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pdf2zh/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,6 +1166,7 @@ def lang_mapping(input_lang: str) -> str:
"""
langdict = {
"zh": "Chinese",
"zh-CN": "Chinese",
"zh-TW": "Chinese",
"en": "English",
"fr": "French",
Expand Down
17 changes: 16 additions & 1 deletion test/test_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@

from pdf2zh import cache
from pdf2zh.config import ConfigManager
from pdf2zh.translator import BaseTranslator, OllamaTranslator, OpenAIlikedTranslator
from pdf2zh.translator import (
BaseTranslator,
OllamaTranslator,
OpenAIlikedTranslator,
QwenMtTranslator,
)

# Since it is necessary to test whether the functionality meets the expected requirements,
# private functions and private methods are allowed to be called.
Expand Down Expand Up @@ -220,5 +225,15 @@ def test_remove_cot_content(self):
)


class TestQwenMtTranslator(unittest.TestCase):
def test_lang_mapping(self):
# Simplified Chinese can be passed as either "zh" or "zh-CN"
self.assertEqual(QwenMtTranslator.lang_mapping("zh"), "Chinese")
self.assertEqual(QwenMtTranslator.lang_mapping("zh-CN"), "Chinese")
self.assertEqual(QwenMtTranslator.lang_mapping("zh-TW"), "Chinese")
self.assertEqual(QwenMtTranslator.lang_mapping("en"), "English")
self.assertEqual(QwenMtTranslator.lang_mapping("ja"), "Japanese")


if __name__ == "__main__":
unittest.main()