Skip to content

Connector scaffold generates a manifest and result that fail our own validators #24

Open

Description

@tnunamak

Following skills/pdp-connect/CREATE.md today does not get you a working connector. The generated manifest fails the repo's own validator, and the generated script produces a result the runtime rejects. A newcomer has no way to tell which part they got wrong, so they end up reverse-engineering ChatGPT or GitHub instead.

Concretely, skills/pdp-connect/templates/connector-metadata.json run through scaffold.cjs is missing 6 of the 12 fields schemas/manifest.schema.json requires:

manifest_version, connector_id, source_id, page_api_version, connect_url, connect_selector

It also emits "status": "experimental" (template L11), which is not in properties and the schema sets additionalProperties: false. And two placeholders are never substituted because they are absent from the scaffold's replacement map, so the output literally contains "id": "{{name}}-playwright" and "name": "{{Platform Name}}". scripts/validate-manifests.mjs enforces the same 12 required fields, so this fails our own gate on the first try.

The script template is worse, because its failure is silent. templates/connector-script.js:179-194 returns a result with no requestedScopes and no errors: [], and sets details to a string where the real shape is an object. The README says every produced scope key must appear in requestedScopes, and a run that violates that is discarded entirely. The template also never calls page.requestedScopes(), so it teaches people to ignore scopes from day one. Compare connectors/openai/chatgpt-playwright.js:586-609 or connectors/github/github-playwright.js:82-98 for what these actually need to emit.

There is a path problem too. CREATE.md:71 documents node scripts/scaffold.cjs connectors/<platform> [company], but scaffold.cjs:13-15 reads argv[2] as the bare platform name and argv[4] as the output directory, defaulting to ~/.pdp-connect/desktop/connectors. So following the doc gives you a connector named connectors/uber, with scope keys like connectors/uber.profile, written outside the repo where the guide's own next step cannot find it. Make the documented command write to an explicit path inside the repo.

Last, the Reference Connectors table (CREATE.md:25-32) lists Reddit and Twitter/X. Neither exists. Point at what we actually have: connectors/github/github-playwright.js, connectors/openai/chatgpt-playwright.js, connectors/meta/instagram-playwright.js. L34 also sends people to ~/.pdp-connect/desktop/connectors/ for examples rather than the repo's own connectors/ tree.

Keep this to the authenticated connector pattern the scaffold already supports. How no-auth or input-only connectors should declare themselves in the manifest is an open question and not one to settle inside a scaffold fix.

The check is that you can follow CREATE.md from a clean checkout, generate a connector inside the repo, and have it pass:

node scripts/validate-manifests.mjs
node skills/pdp-connect/scripts/validate.cjs <your-connector.js>

without copying anything out of an existing connector. If you have to peek at ChatGPT to make the generated file valid, the scaffold still is not done. Neither validator is wired into package.json, so call them by path.

Activity

  1. added a commit that references this issue on Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions