Add support for "ignore (non-negative) elemental resistances" mods#690
Merged
LocalIdentity merged 3 commits intoFeb 4, 2025
Merged
Conversation
… Frost, Choir of the Storm)
majochem
marked this pull request as ready for review
February 3, 2025 11:12
LocalIdentity
approved these changes
Feb 4, 2025
LocalIdentity
changed the title
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
… mods [Heavy Frost, Choir of The Storm] (PathOfBuildingCommunity#690) * add support for additional "ignore elemental resistances" mods (Heavy Frost, Choir of the Storm) * Include "ignore elemental resistance" flags in effective DPS breakdown --------- Co-authored-by: majochem <majochem@users.noreply.github.com>
emptywalls
added a commit
to emptywalls/PathOfBuilding-PoE2
that referenced
this pull request
Jul 13, 2026
…egative elemental resistances" Support for "ignore non-negative elemental resistances" was raised as [2] and implemented with [3], however the implementation did not address resistances inversion. As shown in [1], Rakiatas inversion is done before ignoring. [1] https://youtu.be/2d646c8_m0k?t=428 [2] PathOfBuildingCommunity#498 [3] PathOfBuildingCommunity#690
emptywalls
added a commit
to emptywalls/PathOfBuilding-PoE2
that referenced
this pull request
Jul 13, 2026
…egative elemental resistances" Support for "ignore non-negative elemental resistances" was raised as [2] and implemented with [3], however the implementation did not address resistances inversion. As shown in [1], Rakiatas inversion is done before ignoring. [1] https://youtu.be/2d646c8_m0k?t=428 [2] PathOfBuildingCommunity#498 [3] PathOfBuildingCommunity#690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #498 .
Description of the problem being solved:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
TestBuild
Before screenshot:
None
After screenshot: