Update to new Github style? #1

Activity

1. PhilipTrauner commented on Apr 7, 2020

   

   PhilipTrauner

   on Apr 7, 2020

   Owner

   More actions

   I was pretty surprised to hear that they've reworked the token style, as I've never noticed any changes. After comparing Markdown and how its rendered by different GitHub features I now know why: They don't seem to apply the new style everywhere.

   Here's a quick comparison:

   Unmodified pygments

   

   Modified pygments

   

   GitHub Markdown Preview

   

   GitHub Gist

   

   Unmodified pygments still closely (within the constraints pointed out in the README.md) matches GitHub Markdown Preview.

   GitHub Gist is definitely different though, so I've tried to replicate it by making the following changes which are illustrated by Modified pygments.

   diff --git a/dist/style/github.css b/dist/style/github.css
   index 3af9410..359bd0f 100644
   --- a/dist/style/github.css
   +++ b/dist/style/github.css
   @@ -1,5 +1,5 @@
    .highlight .hll { background-color: #ffffcc }
   -.highlight  { background: #f8f8f8; }
   +.highlight  { background: #f6f8fa; }
    .highlight .c { color: #6a737d } /* Comment */
    .highlight .err {  } /* Error */
    .highlight .k { color: #d73a49 } /* Keyword */
   @@ -29,12 +29,12 @@
    .highlight .m { color: #666666 } /* Literal.Number */
    .highlight .s { color: #032f62 } /* Literal.String */
    .highlight .na { } /* Name.Attribute */
   -.highlight .nb { color: #005cc5 } /* Name.Builtin */
   -.highlight .nc { color: #6f42c1 } /* Name.Class */
   +.highlight .nb { color: #6f42c1 } /* Name.Builtin */
   +.highlight .nc { color: #e36209 } /* Name.Class */
    .highlight .no { color: #005cc5 } /* Name.Constant */
    .highlight .nd { color: #6f42c1 } /* Name.Decorator */
    .highlight .ni { color: #005cc5 } /* Name.Entity */
   -.highlight .ne { color: #005cc5 } /* Name.Exception */
   +.highlight .ne { color: #e36209 } /* Name.Exception */
    .highlight .nf { color: #6f42c1 } /* Name.Function */
    .highlight .nl { color: #005cc5 } /* Name.Label */
    .highlight .nn { color: #6f42c1 } /* Name.Namespace */

   I'm not opposed to pushing these to master, so please me know if you are satisfied with the result 🙂
2. fladd commented on Apr 7, 2020

   

   fladd

   on Apr 7, 2020

   Author

   More actions

   Looks good.

   Some more observations:

   1. Shouldn't things like "is" and "not" in Python be blue, rather than orange.

   2. I also spotted some other differences in other languages (HTML, Ruby, C++). Not sure if they were related to changes at GitHub or due to limitations of Pygments.

      Have a look at those examples here: https://gist.github.com/fladd/3280e197f0b9d6958c25b121e7ac3390

   3. You could also consider switching on operators. Since they are blue now, the additional colouring of dots by Pygments is barely seen and not too distracting.
3. fladd commented on Feb 25, 2021

   

   fladd

   on Feb 25, 2021

   Author

   More actions

   Any news on this?
4. PhilipTrauner commented on Feb 26, 2021

   

   PhilipTrauner

   on Feb 26, 2021

   Last edited by PhilipTrauner

   Owner

   More actions

   Don't have time to perform these changes right now, but would still be open to merging this in if you put together a PR. (please update the "Compromises" table as well) 🙂