Convert levels to weights in compute_uncertainty - #34
Merged
mcm001 merged 1 commit intoSep 20, 2026
Merged
Conversation
thatcomputerguy0101
force-pushed
the
uncertainty-levels-to-weights
branch
from
September 19, 2026 17:49
753c821 to
02ecb3c
Compare
mcm001
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute_uncertaintywas documented as taking levels, but was directly passing the data to mrcal, which expected weights, without doing any conversion. This fixes the problem by adding level to weight conversion tocompute_uncertainty. This passes the PV uncertanty tests once modified with the correct level.