Repository navigation
Conversation
Rotated glyphs in VerticalMixed layouts now get the OpenType vrtr feature. Its glyphs are designed to be rotated by the layout engine, so they are still rotated synthetically. vrt2 is still never applied by default. A vrt2 requested in TextOptions.FeatureTags is now skipped for glyphs that are rotated in vertical mixed layout, because its pre-rotated glyphs were rotated twice. Closes #51
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Summary
Feature planning per glyph in
DefaultShaper:for each glyph if upright (IsVerticalGlyph) add vert else add calt, clig, liga, rclt, curs, kern + if layout is VerticalMixed* + add vrtr # still rotated synthetically for each user feature - add to every glyph + if feature is vrt2 and layout is VerticalMixed* + add to upright glyphs only # vrt2 glyphs are pre-rotated + else + add to every glyphvertvrtrvrt2is never added by default.TextOptions.FeatureTagsdocuments thevrt2rule. CHANGELOG has entries under Unreleased.Evidence
UserVrt2DoesNotRotateRotatedGlyphTwiceInVerticalMixedLayoutfails. NotoSansKR,VerticalMixedRightLeft,FeatureTags = [vrt2], textあ…い: U+2026 (orientation R) becomes vrt2 glyph 21602 and is then rotated as well.RotatedGlyphIsShapedWithVrtrInVerticalMixedLayoutfails, because the planned features have novrtr.Gap (as the brief requires): no test font has a
vrtrfeature, so there is no end-to-endvrtrsubstitution test.vrtris tested at the shaper-plan seam: rotated glyphs get it, upright glyphs and non-mixed modes do not. Synthetic rotation ofvrtrglyphs is unchanged by construction, because the rotation path is not touched.Merge Danger
Door: two-way
No public API change. A revert restores the old behaviour.
Blast Radius: narrow
Only vertical mixed layouts change. For fonts with a
vrtrfeature, rotated glyphs can change to the font'svrtrforms. Users who requestvrt2in vertical mixed layout no longer get pre-rotated glyphs on rotated runs. Output for every other font and mode is unchanged.