feat: use Player#getPing for 1.17+ - #83
Merged
Merged
Conversation
By doing this we won't need to update the expansion on every release that changes the name of the ping field
I somehow forgot to commit this 🤦♂️
BlitzOffline
approved these changes
Jun 20, 2023
Tanguygab
added a commit
to Tanguygab/Player-J17-Expansion
that referenced
this pull request
Aug 25, 2023
Closed
|
Please release an update fixing errors with 1.20+ related to this. |
Member
Author
|
|
1.20.2 broke it again and the 2.0.6 release doesn't use the getPing() method from Spigot API yet so it still tries to find the field from older versions |
|
For me it shows that the latest version is 2.0.5 updated on June 16, 2023, this pull request was merged on August 27, 2023. |
Member
Author
|
Ahh I see. I will release an update in a few. |
Member
Author
|
It is live @NicoNekoDev you can download it manually from the eCloud, it will take 1-2h to be available in game due to caching. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This was suggested by @Tanguygab on discord: