Repository navigation
fix(contact): include unresolved person IDs in filters - #76
Merged
Merged
Conversation
Person filters ignored raw IDs without matching SocialIdentity documents, leaving system-origin authors unselectable. Include and label those IDs while avoiding false unresolved entries during searches. Fixes hcengineering/platform#8670 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
ArtyomSavchenko
approved these changes
Oct 20, 2026
ArtyomSavchenko
merged commit Oct 20, 2026
cbff2f4
into
Platform-Collective:develop
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Person filters ignored raw IDs without matching SocialIdentity
documents, leaving system-origin authors unselectable. Include and
label those IDs while avoiding false unresolved entries during searches.
Fixes hcengineering/platform#8670 (the issue was reported upstream before the move to Platform-Collective).
Changed files
plugins/contact-resources/src/components/PersonIdFilter.svelteplugins/contact-resources/src/components/person-id-filter.test.tsplugins/contact-resources/src/components/person-id-filter.tsTesting
build,formatting,svelte-checkandtestpass. Theuitestjobs failed there in planner, Gantt download and indexer specs that fail the same way on branches with unrelated changes, so they look pre-existing/flaky rather than caused by this change.