You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 4, 2021. It is now read-only.
The plugin server has a bunch of objects that it manages. A central one is called just "server", which contains all connections to various databases and some adapters to query them (PG, Redis, ClickHouse, Kafka, etc).
The name clashes with the "server" in "plugin server", which is the main entrypoint to the app.
Proposal: let's rename the connection object from "server" to "hub" to better reflect its intended usage.
Big +1, I was thinking about an alternative name for some time but didn't come up with anything solid – hub sounds reasonable. Created #425 which makes this change.
I thought of connections as well initially, but it's not descriptive enough IMO. Hub also contains logic and abstractions over the various connections, so... :).
Activity
neilkakkar commentedon May 24, 2021
Agree with this: or
connections.When first reading about the Plugin Server, I was very confused why there was a
serverinside thePluginServerthat wasn't thePluginServer.tsTwixes commentedon May 24, 2021
Big +1, I was thinking about an alternative name for some time but didn't come up with anything solid –
hubsounds reasonable. Created #425 which makes this change.mariusandra commentedon May 25, 2021
I thought of
connectionsas well initially, but it's not descriptive enough IMO. Hub also contains logic and abstractions over the various connections, so... :).