Skip to content
This repository was archived by the owner on Nov 4, 2021. It is now read-only.
This repository was archived by the owner on Nov 4, 2021. It is now read-only.

Proposal: rename "server" to "hub". #422

Closed

Description

@mariusandra

The plugin server has a bunch of objects that it manages. A central one is called just "server", which contains all connections to various databases and some adapters to query them (PG, Redis, ClickHouse, Kafka, etc).

The name clashes with the "server" in "plugin server", which is the main entrypoint to the app.

Proposal: let's rename the connection object from "server" to "hub" to better reflect its intended usage.

Activity

  1. neilkakkar commented on May 24, 2021

    @neilkakkar
    Contributor

    Agree with this: or connections.

    When first reading about the Plugin Server, I was very confused why there was a server inside the PluginServer that wasn't the PluginServer.ts

  2. Twixes commented on May 24, 2021

    @Twixes
    Contributor

    Big +1, I was thinking about an alternative name for some time but didn't come up with anything solid – hub sounds reasonable. Created #425 which makes this change.

  3. mariusandra commented on May 25, 2021

    @mariusandra
    CollaboratorAuthor

    I thought of connections as well initially, but it's not descriptive enough IMO. Hub also contains logic and abstractions over the various connections, so... :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions