Repository navigation
fix: Surveys: an optional rating question with response-based branching throws "The response type must be an integer" when skipped - #5279
Open
github-actions[bot] wants to merge 3 commits into
Conversation
…ranching throws "The r
Contributor
Author
Coherence2 spec problems · 0 failing chokepoints · 2 spec gaps · 0 guard failures 44 components, 5 bullets (5 invariants, 0 requirements), 2 problems Spec problems (spec --check)
Chokepoints: none declared. Spec gaps: 2 entrances with outside or unknown trust and no traced control, and 10 more held by the adoption baseline
Close one with |
Contributor
Author
Contributor
Author
|
Size Change: +579 B (0%) Total Size: 24.1 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
Author
posthog-js Compliance ReportDate: 2026-10-12 18:17:58 UTC ✅ All Tests Passed!26/26 tests passed Capture Tests✅ 26/26 tests passed View Details
|
dustinbyrne
marked this pull request as ready for review
October 12, 2026 18:32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #5278
Skipping an optional rating question with response-based branching throws instead of taking the default next-question path.
Changes
The defect is isolated to one validation path and does not require a public API or survey-schema change. The existing component behavior establishes that null is the intentional skipped value for optional ratings.
Changed files
.changeset/fix-optional-rating-survey-branching.mdpackages/browser/src/__tests__/surveys.test.tspackages/browser/src/utils/survey-branching.tsValidation
No validation command configured.
No validation command configured.
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Fully autonomous
Generated by posthog-watcher-action using pi.