Skip to content

chore: clear the Coherence spec problems reported on every PR - #5303

Open
pauldambra wants to merge 1 commit into
mainfrom
posthog/fix-coherence-spec-problems
Open

pauldambra wants to merge 1 commit into
mainfrom
posthog/fix-coherence-spec-problems

Conversation

@pauldambra

Copy link
Copy Markdown
Member

Robot note: this PR text was written by the PostHog Slack app for @pauldambra.

Problem

The Coherence report on every PR shows spec problems that no PR author caused. Two come from Posthog-js.practice.md, which cites two commits that exist in no branch of this repo. Two come from Otel.spec.md, whose bullets have no <name>: <sentence> form.

Changes

  • Remove the two missing commit ids from the learned: line of the "add an invariant" practice. The decision id stays.
  • Give the two Otel.spec.md bullets a name. I did not add enforcement, kinds or because: lines: the check still shows them as lacking, so the gap stays visible instead of being filled with guesses.
  • coherence spec --check now ends with 0 problems. The missing-commit check needs full git history, so it is confirmed by the Coherence CI run on this PR, not locally.

Release info Sub-libraries affected

Libraries affected

  • None. Spec and practice files only, nothing is published.

Checklist

  • Tests for new code
  • Accounted for the impact of any changes across different platforms
  • Accounted for backwards compatibility of any changes (no breaking changes!)
  • Took care not to unnecessarily increase the bundle size

Created with PostHog from a Slack thread

Drop two commit ids from the add-an-invariant practice that exist in no branch of this repo, and give the two Otel spec bullets a name so spec --check passes.

Generated-By: PostHog Desktop
Task-Id: 822cb54b-55fa-4576-a107-1e406f72d9de
@pauldambra pauldambra self-assigned this Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor
⚠️ `@posthog/ai` is modified but this PR has no changeset

This is informational — the PR is not blocked. Click the triangle above to collapse, or push a fix and this comment will auto-delete.

Modified in this PR but no changeset added:

  • @posthog/ai

If this change should ship, run pnpm changeset and select a bump level.
If it isn't user-facing (refactor with no behavior change, internal tooling, generated files), no action needed.

@github-actions

Copy link
Copy Markdown
Contributor

📝 No Changeset Found

This PR doesn't include a changeset. A changeset is required to release a new version.

How to add a changeset

Run this command and follow the prompts:

pnpm changeset

Remember: Never use major version bumps for posthog-js as it's autoloaded by clients.

@github-actions

Copy link
Copy Markdown
Contributor

Coherence

0 spec problems · 0 failing chokepoints · 2 spec gaps · 0 guard failures

44 components, 7 bullets (5 invariants, 2 requirements), 0 problems

Chokepoints: none declared.

Spec gaps: 2 entrances with outside or unknown trust and no traced control, and 10 more held by the adoption baseline

  • packages/web/Web.spec.md entrance public api (trust host-app): packages/web
  • packages/webpack-plugin/Webpack-plugin.spec.md entrance webpack plugin (trust build): packages/webpack-plugin

Close one with guard: <chokepoint>, an invariant that names it on its entrances: line, or control: none — <reason>; scaffold control proposes it.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T08:45:01.874307Z e1fa476 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants