Repository navigation
chore: clear the Coherence spec problems reported on every PR - #5303
pauldambra wants to merge 1 commit into
Conversation
Drop two commit ids from the add-an-invariant practice that exist in no branch of this repo, and give the two Otel spec bullets a name so spec --check passes. Generated-By: PostHog Desktop Task-Id: 822cb54b-55fa-4576-a107-1e406f72d9de
|
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Coherence0 spec problems · 0 failing chokepoints · 2 spec gaps · 0 guard failures 44 components, 7 bullets (5 invariants, 2 requirements), 0 problems Chokepoints: none declared. Spec gaps: 2 entrances with outside or unknown trust and no traced control, and 10 more held by the adoption baseline
Close one with |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Robot note: this PR text was written by the PostHog Slack app for @pauldambra.
Problem
The Coherence report on every PR shows spec problems that no PR author caused. Two come from
Posthog-js.practice.md, which cites two commits that exist in no branch of this repo. Two come fromOtel.spec.md, whose bullets have no<name>: <sentence>form.Changes
learned:line of the "add an invariant" practice. The decision id stays.Otel.spec.mdbullets a name. I did not add enforcement, kinds orbecause:lines: the check still shows them as lacking, so the gap stays visible instead of being filled with guesses.coherence spec --checknow ends with 0 problems. The missing-commit check needs full git history, so it is confirmed by the Coherence CI run on this PR, not locally.Release info Sub-libraries affected
Libraries affected
Checklist
Created with PostHog from a Slack thread