Skip to content

Refactor some base Funnel query components - #5037

Merged
neilkakkar merged 9 commits into
masterfrom
refactor
Jul 8, 2021
Merged

neilkakkar merged 9 commits into
masterfrom
refactor

Conversation

@neilkakkar

Copy link
Copy Markdown
Contributor

Changes

Clean up 🤵 ✂️

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar
neilkakkar requested review from EDsCODE and Twixes July 8, 2021 10:40
@timgl
timgl temporarily deployed to posthog-pr-5037 July 8, 2021 10:41 Inactive
@timgl
timgl temporarily deployed to posthog-pr-5037 July 8, 2021 10:52 Inactive

@EDsCODE EDsCODE left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from mixnmatch to master July 8, 2021 16:38
@timgl
timgl temporarily deployed to posthog-pr-5037 July 8, 2021 17:16 Inactive

@Twixes Twixes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@neilkakkar
neilkakkar merged commit 7954477 into master Jul 8, 2021
@neilkakkar
neilkakkar deleted the refactor branch July 8, 2021 17:25

This branch was previously deployed

1 inactive deployment
posthog-pr-5037 — e6d83a52 Deployed Jul 8, 2021 by timgl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants