Skip to content

Resolve Action.DoesNotExist Errors - #5055

Merged
Twixes merged 1 commit into
masterfrom
actionfix
Jul 9, 2021
Merged

Twixes merged 1 commit into
masterfrom
actionfix

Conversation

@neilkakkar

Copy link
Copy Markdown
Contributor

Changes

Follow up to : #5028
and resolves https://sentry.io/organizations/posthog/issues/2502517141/?project=1899813

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar
neilkakkar requested a review from Twixes July 9, 2021 08:51
Comment thread posthog/queries/funnel.py
def _serialize_step(self, step: Entity, count: int, people: Optional[List[uuid.UUID]] = None) -> Dict[str, Any]:
if step.type == TREND_FILTER_TYPE_ACTIONS:
name = Action.objects.get(team=self._team.pk, pk=step.id).name
name = step.get_action().name

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually sure how things made it here without erroring out first O.o

@timgl
timgl temporarily deployed to posthog-pr-5055 July 9, 2021 08:53 Inactive
@Twixes
Twixes merged commit f73193c into master Jul 9, 2021
@Twixes
Twixes deleted the actionfix branch July 9, 2021 09:30

This branch was previously deployed

1 inactive deployment
posthog-pr-5055 — f4f691e2 Deployed Jul 9, 2021 by timgl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants