Repository navigation
Run broken down analyses with a single SQL query - #5186
Merged
Merged
Conversation
EDsCODE
approved these changes
Jul 21, 2021
EDsCODE
added a commit
that referenced
this pull request
Jul 21, 2021
6 tasks
Collaborator
|
Note: This isn't plausible atm because CTEs don't work as expected with distributed tables yet |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Production-ready #5072:
Currently our ClickHouse analyses require an additional SQL query when using breakdown – for obtaining values to break down by. This impacts speed and therefore user experience, because an additional query round trip before the proper query takes time. We can do away with this using common table expressions though – this way the same breakdown values query is ran before the proper analysis one all in the same query string.
Checklist