Skip to content

Allow mix-n-matching Funnel types in cache update - #5399

Merged
neilkakkar merged 4 commits into
masterfrom
cache_update
Aug 2, 2021
Merged

neilkakkar merged 4 commits into
masterfrom
cache_update

Conversation

@neilkakkar

Copy link
Copy Markdown
Contributor

Changes

Follow up to #5051 - it's not a problem yet, but would've been once support for different orderings is introduced.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar
neilkakkar requested review from EDsCODE and Twixes July 30, 2021 13:39
@neilkakkar neilkakkar changed the title Allow mix-n-matching in cache update Allow mix-n-matching Funnel types in cache update Jul 30, 2021
@timgl
timgl temporarily deployed to posthog-pr-5399 July 30, 2021 13:41 Inactive

@Twixes Twixes left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Do we have caching tests for this though?

@neilkakkar

Copy link
Copy Markdown
Contributor Author

Nope, I'm guessing that's why things were passing before as well. Will add them here :)

@timgl
timgl temporarily deployed to posthog-pr-5399 August 2, 2021 14:02 Inactive
@timgl
timgl temporarily deployed to posthog-pr-5399 August 2, 2021 14:12 Inactive
@neilkakkar
neilkakkar requested a review from Twixes August 2, 2021 16:17
@neilkakkar
neilkakkar merged commit 73d85c9 into master Aug 2, 2021
@neilkakkar
neilkakkar deleted the cache_update branch August 2, 2021 16:55

This branch was previously deployed

1 inactive deployment
posthog-pr-5399 — 70d67205 Deployed Aug 2, 2021 by timgl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants