Fix detection of Windows PS vs PS Core resolving module directory issues

[Borgquite]

PR Summary

Fix detection of Windows PS vs PS Core resolving module directory issues

PR Context

Switch to using PSEdition instead of Host.Version as running PowerShell under certain instances does not return correct version (e.g. VSCode, .NET Interactive, Ruby/Puppet)

• Fixes Incorrect module path when using .NET interactive #463
• Fixes Polyglot notebooks PSModule path is pointed at Windows PowerShell #881
• Fixes Incorrect resource directories when run in VSCode Terminal #1459

The PSEdition variable returns $null, or 'Desktop' under Windows PowerShell, and 'Core' under PowerShell Core. The code therefore checks for 'Core' to determine if Core is in use - otherwise, it determines Windows PowerShell.

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_powershell_editions?view=powershell-7.5

This is the method preferred by the PowerShell team for identifying the use of PowerShell Core, rather than using version numbers

https://devblogs.microsoft.com/scripting/powertip-identify-if-you-are-running-on-powershell-core/

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[Borgquite]

@microsoft-github-policy-service agree company="Mission Aviation Fellowship International"

[Borgquite]

Is anyone able to review this simple change that should resolve a number of people's issues with the module?

[o-l-a-v]

@alerickson, @anamnavi

[andyleejordan]

Core problem is identified correctly. The Host value is not deterministic and shouldn't be relied on for this, but yes PSEdition should.

[Borgquite]

Any chance of a review & merge here please?

[anamnavi]

LGTM