Support iluvatar devices - #75
qiangwei1983 wants to merge 1 commit into
Conversation
Signed-off-by: 魏强 <qiang.wei@iluvatar.com>
|
Welcome @qiangwei1983! It looks like this is your first PR to Project-HAMi/HAMi-WebUI 🎉 |
Nimbus318
left a comment
There was a problem hiding this comment.
Thanks for bringing Iluvatar support to HAMi-WebUI. The feature is still needed and no newer PR replaces it, but this branch now needs correctness updates against the current producer contracts:
- HAMi supports BI-V100, BI-V150, MR-V100 and MR-V50, plus configurable commonWords; this implementation hard-codes three families and stops after the first registration annotation.
- container_gpu_memory_total reports used memory in MiB, not a percentage. The container metrics also expose per-device and total series and include namespace identity, so the current averaging and conversion can produce incorrect values or mix same-named workloads across namespaces.
Please rebase onto current main, align with the current device-decoder and missing-telemetry contracts, query the exact labels and units, and add focused provider/decoder/exporter tests plus Iluvatar environment evidence. Splitting inventory/allocation support from telemetry would make the change easier to validate.
Requesting changes while keeping this open because the contribution is valuable.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qiangwei1983 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Support iluvatar devices