Skip to content

Support iluvatar devices - #75

Open
qiangwei1983 wants to merge 1 commit into
Project-HAMi:mainfrom
qiangwei1983:main
Open

qiangwei1983 wants to merge 1 commit into
Project-HAMi:mainfrom
qiangwei1983:main

Conversation

@qiangwei1983

Copy link
Copy Markdown

Support iluvatar devices

Signed-off-by: 魏强 <qiang.wei@iluvatar.com>
@hami-robot

hami-robot Bot commented Jan 14, 2026

Copy link
Copy Markdown

Welcome @qiangwei1983! It looks like this is your first PR to Project-HAMi/HAMi-WebUI 🎉

@hami-robot hami-robot Bot added the size/L label Jan 14, 2026

@Nimbus318 Nimbus318 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing Iluvatar support to HAMi-WebUI. The feature is still needed and no newer PR replaces it, but this branch now needs correctness updates against the current producer contracts:

  • HAMi supports BI-V100, BI-V150, MR-V100 and MR-V50, plus configurable commonWords; this implementation hard-codes three families and stops after the first registration annotation.
  • container_gpu_memory_total reports used memory in MiB, not a percentage. The container metrics also expose per-device and total series and include namespace identity, so the current averaging and conversion can produce incorrect values or mix same-named workloads across namespaces.

Please rebase onto current main, align with the current device-decoder and missing-telemetry contracts, query the exact labels and units, and add focused provider/decoder/exporter tests plus Iluvatar environment evidence. Splitting inventory/allocation support from telemetry would make the change easier to validate.

Requesting changes while keeping this open because the contribution is valuable.

@hami-robot

hami-robot Bot commented Aug 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qiangwei1983
Once this PR has been reviewed and has the lgtm label, please assign nimbus318 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nimbus318 Nimbus318 added the kind/feature Adds new user-visible behavior label Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes kind/feature Adds new user-visible behavior size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants