Add node 10 builds to travis - #5246
Merged
Merged
Conversation
Member
|
danpaz
force-pushed
the
node-10-builds
branch
from
October 30, 2018 14:12
38a6bd6 to
543f5a9
Compare
Contributor
Author
|
Node 4 build is failing because yarn 1.12.1 is not compatible with node 4. I think it's reasonable to drop node 4 as it's been EOL for several months, any objections? |
danpaz
force-pushed
the
node-10-builds
branch
from
October 30, 2018 23:01
543f5a9 to
bdc45a1
Compare
Contributor
Author
danpat
approved these changes
Dec 4, 2018
danpaz
force-pushed
the
node-10-builds
branch
from
December 4, 2018 18:39
bdc45a1 to
d669d16
Compare
ghoshkaj
pushed a commit
that referenced
this pull request
Dec 4, 2018
* Add node 10 builds to travis * Add changelog
ghoshkaj
added a commit
that referenced
this pull request
Dec 10, 2018
* Prepare RC.1 * Bump version. * remove destination/sources length <= coordinates length check (#5289) * Add node 10 builds to travis (#5246) * Add node 10 builds to travis * Add changelog * bump version to rc5 * Fix fallback_speed vector access (#5291) * add failing cuke test * correctly access durations vector * changelog * one more cuke test * bump rc version * 5.20.0 * remove line from changelog about commit that isn't actually in here * update CHANGELOG and osrm version in package.json for v5.20.0 * bump to restart appveyor
5 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #5245. The change here is just copypasta from the other node builds.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?