Skip to content
Discussion options

You must be logged in to vote

Good catch, that was a bug. ITransferValidator721.validateTransfer is view and the token calls it with STATICCALL, so the ERC-721 contracts now return isViewFunction = true: on main in #196 and on v2 in #195. Contracts deployed before then still report false, but their transfers are validated the same way. The ERC-1155 contracts return false on purpose: ITransferValidator1155.validateTransfer takes an amount and can reduce what's left to transfer, so it isn't view.

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected by ryanio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants