Repository navigation
Replace npm with pinned lint tools (v2) - #230
Merged
Merged
Conversation
Same change as on main: scripts/install-tools.sh pins Biome, taplo, lefthook, shellcheck, shfmt and actionlint by version and SHA-256, and scripts/lint.sh runs what CI runs, including the Seaport pragma patch before forge lint. Biome is pinned at 2.6.3. Removes package.json, package-lock.json and .nvmrc, and the Node steps from CI. The shell scripts are reindented for shfmt, and seven unquoted variables shellcheck flagged are quoted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the migration to pinned, checksum-verified development tools.
No open issues 🎉
What changed in this PR
Replaces SeaDrop v2’s npm-based development tooling with pinned, checksum-verified binaries, aligning with Seaport’s approach. No Solidity code changes are included.
Changes:
- Removes Node/npm dependencies and adds standalone tool installation and lint scripts.
- Updates CI and pre-commit hooks to use pinned tools, adding TOML, shell, and workflow checks.
- Updates contributor documentation, standardizes shell formatting, and quotes shell variables.
| File | Description |
|---|---|
scripts/patch_seaport_pragmas.sh |
Adjusts indentation for shfmt. |
scripts/lint.sh |
Adds local check and formatting commands matching CI. |
scripts/install-tools.sh |
Installs six pinned tools with SHA-256 verification. |
scripts/forge_script_multichain.sh |
Quotes command arguments and standardizes formatting. |
scripts/find_optimizer_runs.sh |
Quotes variables and standardizes formatting. |
scripts/check_sizes.sh |
Adjusts indentation for shfmt. |
scripts/check_deployments.sh |
Quotes variables and standardizes formatting. |
package.json |
Removes npm dependencies and command wrappers. |
package-lock.json |
Removes the npm dependency lockfile. |
lefthook.yml |
Uses local binaries and expands staged-file formatting. |
docs/Development.md |
Documents standalone tooling and replacement commands. |
biome.json |
Aligns the schema with pinned Biome 2.6.3. |
AGENTS.md |
Updates build, lint, and tool installation guidance. |
.taplo.toml |
Configures TOML formatting. |
.nvmrc |
Removes the Node version pin. |
.gitignore |
Replaces the npm directory exclusion with .tools/. |
.github/workflows/test.yml |
Caches pinned tools and adds lint checks without npm. |
.editorconfig |
Defines shared whitespace and indentation settings. |
Review effort: Balanced
ryanio
added a commit
that referenced
this pull request
Nov 10, 2026
Fixes the issue Copilot found on [seadrop#229](#229 (comment)) for v2, since #230 already merged. `scripts/install-tools.sh` extracted archives with `tar ... && mv ...`. Under `set -e`, bash ignores a failure on the left of `&&`, so if `tar` failed while updating an installed tool, the script kept the old binary, recorded the new checksum and reported success. Later runs then skipped the stale binary. The extraction and the move are now separate commands, so a failed extraction stops the install. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ryanio
added a commit
that referenced
this pull request
Nov 10, 2026
The README version badge read `version` from `package.json`, which [#230](#230) removed. It now shows the version v2's `package.json` had, 2.0.0, as a static badge linking to the v2 branch. The old link also pointed at main's `package.json`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeaDrop's only npm dependencies were two dev tools, Biome and lefthook. This replaces them with the same pinned tooling seaport now uses (seaport#1429), so the repo has no Node or npm dependencies at all.
scripts/install-tools.shdownloads Biome, taplo, lefthook, shellcheck, shfmt and actionlint from their GitHub releases into.tools/bin, and checks each file against a pinned SHA-256. It's the same script as seaport's.scripts/lint.sh checkruns what CI runs:forge fmt --check, the Seaport pragma patch,forge lint --deny warnings, Biome, taplo, shellcheck, shfmt and actionlint.scripts/lint.sh fixapplies the formatters.npm ci.package.json,package-lock.jsonand.nvmrcare gone..gitignoreignores.tools/instead ofnode_modules.package.jsonhad, was released on November 6, which is under the two weeks we wait before pinning a release. Its output on this repo is unchanged.lefthook.ymlruns the binaries from.tools/binand also formats TOML and shell scripts.check_deployments.sh,find_optimizer_runs.shandforge_script_multichain.share now quoted.npm runcommands with the scripts and the plain build command.No Solidity changes. The same change for
mainis seadrop#229.🤖 Generated with Claude Code