Repository navigation
fix: separate the order index from the identifier in ERC721 aggregate keys - #1051
Closed
Ocheretovich wants to merge 1 commit into
Closed
Ocheretovich wants to merge 1 commit into
Ocheretovich wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 98.27% 99.14% +0.86%
==========================================
Files 35 58 +23
Lines 14526 21279 +6753
Branches 660 1215 +555
==========================================
+ Hits 14276 21096 +6820
+ Misses 245 175 -70
- Partials 5 8 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 30, 2026
Collaborator
|
Thanks @Ocheretovich, good catch. Both new cases fail with the separator reverted. For the record: the collision needs at least 11 orders from the same offerer and collection in one Five PRs touched overlapping files this week, so this was stacked in #1058 with your commit unchanged, and it shipped in v4.5.0. Closing in favor of #1058. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #932 (issue #926).
When building fulfillment groups, ERC721 keys get
orderIndex-itemIndexappended right after the token id, with no separator. So two different NFTs can produce the same key: id1in order11and id11in order1both become...-111-0, and end up in one group.The fix adds a
-before the index (two places infulfill.ts).Tests: a new spec covers the offer and consideration sides. Both cases fail on
mainand pass with the fix. Lint andfulfill-utils.spec.tsare green.Checked at the fulfillment-generation level only; I did not run an on-chain fulfill with such a batch.