Skip to content

build: compile Seaport from seaport-core instead of the seaport repo - #1079

Merged
ryanio merged 1 commit into
mainfrom
ryan/seaport-core-dep
Nov 10, 2026
Merged

ryanio merged 1 commit into
mainfrom
ryan/seaport-core-dep

Conversation

@ryanio

@ryanio ryanio commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Motivation

seaport-js installs the whole seaport repo as a git npm dependency (pinned to 0801339) for three Solidity files and one interface. The seaport repo is moving off npm (modernization series), and npm git dependencies need a package.json, so the pin could never move forward after that. The git dependency also pulled in the seaport repo's own dependencies.

Solution

Compile Seaport from the packages the seaport repo itself builds from:

  • seaport-core 1.6.6 and seaport-types 1.6.3, pinned exactly. They are the source verified onchain for the deployed Seaport 1.6, and they're what the pinned seaport commit compiled anyway: its Seaport.sol and conduit files are thin wrappers that import from seaport-core 1.6.6.
  • npmFilesToBuild and the three src/contracts wrappers now point at seaport-core, and TestExtraDataZone imports ZoneInterface from seaport-types.
  • The seaport repo's LocalConduitController was an empty wrapper around seaport-core's ConduitController, so the tests now use ConduitController directly.
  • The internal typechain import path for the Seaport contract moves from typechain-types/seaport/contracts/Seaport to typechain-types/seaport-core/src/Seaport. The public exports (Seaport, ItemType, getMaximumSizeForOrder) don't change.

The lockfile drops 233 packages, including ethers v5 and ethereumjs, that came in only through the seaport repo's package.json. Nothing is added.

Verification

  • Clean npm run build (Hardhat compile, typechain, tsc)
  • npm run lint: typecheck and Biome pass. The 3 Biome warnings were already there, in files this PR doesn't touch.
  • npm test: 309 passing, the same as main

🤖 Generated with Claude Code

The seaport git dependency (pinned to 0801339) only supplied Seaport,
the conduit contracts, and ZoneInterface, all of which come from
seaport-core 1.6.6 and seaport-types 1.6.3: the exact source verified
for the deployed Seaport 1.6. Depending on them directly drops 233
packages that the seaport repo's own package.json pulled in, and keeps
seaport-js working as the seaport repo moves off npm.

LocalConduitController was an empty wrapper around seaport-core's
ConduitController, so tests use ConduitController directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the migration to published seaport-core and seaport-types dependencies.

No open issues 🎉

What changed in this PR

This PR switches seaport-js contract compilation from the Seaport Git dependency to published seaport-core and seaport-types packages, reducing build dependencies while preserving the SDK’s public exports.

Changes:

  • Pins seaport-core and seaport-types directly and removes dependencies pulled in by the Seaport repository.
  • Updates Solidity imports, Hardhat compilation targets, and generated TypeChain import paths.
  • Updates test fixtures and conduit tests to use ConduitController directly.
File Description
test/​utils/​setup.ts Deploys Seaport and ConduitController from core artifacts.
test/​create-bulk-orders.spec.ts Uses the ConduitController factory for bulk-order tests.
test/​conduit.spec.ts Uses the ConduitController factory for conduit tests.
src/​utils/​fulfill.ts Updates generated Seaport type imports.
src/​types.ts Updates the underlying SeaportContract type import.
src/​contracts/​test/​TestExtraDataZone.sol Imports ZoneInterface from seaport-types.
src/​contracts/​Seaport.sol Imports Seaport from seaport-core.
src/​contracts/​ConduitController.sol Imports ConduitController from seaport-core.
src/​contracts/​Conduit.sol Imports Conduit from seaport-core.
package.json Replaces the Git dependency with exact package pins.
package-lock.json Records direct dependencies and removes unused transitive packages.
hardhat.config.ts Targets seaport-core contracts for compilation.

Review effort: Balanced

@ryanio
ryanio merged commit 9b61bac into main Nov 10, 2026
9 checks passed
@ryanio
ryanio deleted the ryan/seaport-core-dep branch November 10, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants