Skip to content

username already taken check? #99

Open

Description

@frollard

def change_discourse_username(username, new_username):

I presume discourse returns a 400ish error but we're not checking for it before trying to change names; don't want to test on live.

Activity

  1. tanner37 commented on Oct 30, 2022

    @tanner37
    Contributor

    Yeah Discourse will return an error in this case. But this won't be checked if there's a name collision on sign up (ie. another tanner.collin signs up to Spaceport), which can't happen because Spaceport will prevent signup unless someone set a custom first.last Discourse username that matches. We'll cross that bridge when it comes. first.last was kind of a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions