Repository navigation
Fixed animation graph time advance bug - #30
Draft
AbdallahFH wants to merge 2 commits into
Draft
AbdallahFH wants to merge 2 commits into
AbdallahFH wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Shared timing introduces unresolved playback-control, initialization, and weight-handling regressions.
5 open findings
What changed in this PR
Addresses #416 by advancing weighted animation blends with a shared, weight-dependent clock rather than the first input’s timing.
Changes:
- Blends input durations and sync tracks, then synchronizes child updates.
- Tracks blend playback state independently.
- Updates shader source-line directives without changing shader logic.
| File | Description |
|---|---|
| Quill/Samples/UnityExample/Assets/Quill/QuillShader.shader | Updates generated source-line mappings. |
| Motion/Motion/Graph/Nodes/BlendNodes.cs | Introduces shared timing for weighted animation blends. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AbdallahFH
marked this pull request as draft
October 16, 2026 21:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I just fixed that bug in the animation crossfade, animation graph? 416
before:
https://github.com/user-attachments/assets/318b58b9-e8ee-4d45-b838-57b2bccc00df
After:
https://github.com/user-attachments/assets/030eefbc-7dc0-4f90-8520-3104f5ff0996