Fixed #28 -- relaxed E301 for nested definitions - #232
Closed
chrismedrela wants to merge 1 commit into
Closed
Conversation
Closed
Contributor
|
Are you still interested in merging this one? In that case I will resolve the conficts. |
Member
There was a problem hiding this comment.
This isn't actually perfect. Take for example:
# pkg/compat.py
"""Compat module for <library>."""
import collections
try:
from collections import OrderedDict
except ImportError:
class OrderedDict(collections.MutableMapping):
# ...
try:
from urlparse import urlparse
except ImportError:
from urllib.parse import urlparse# pkg/something.py
from .compat import OrderedDict
#...That's a global class and that line does not start with class instead it starts with class.
Member
|
FWIW, I agree with Florent that the checks shouldn't necessarily be relaxed but should instead be a separate error code. It gives users a lot more flexibility in how they configure pep8 |
Member
|
#555 superseded this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.