Skip to content

Add contributing instructions. - #566

Merged
sigmavirus24 merged 2 commits into
PyCQA:masterfrom
daspecster:update-contributing-rst
Aug 2, 2016
Merged

Add contributing instructions.#566
sigmavirus24 merged 2 commits into
PyCQA:masterfrom
daspecster:update-contributing-rst

Conversation

@daspecster

Copy link
Copy Markdown
Contributor

Hello!
I noticed from #521, that you guys were looking for something like this to cut the next release.

Let me know if there is anything you want to change or add!

Comment thread CONTRIBUTING.rst

Github has an excellent `guide`_ that has screenshots on how to do this.

Next, clone your fork of the pycodestyle repository to your system for

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to be Step 2 ? If not, you just need to renumber steps 3 and 4 below to 2 and 3.

@IanLee1521

Copy link
Copy Markdown
Member

This looks great, thank you! Just one comment on step numbering, then should be good to merge.

Comment thread CONTRIBUTING.rst Outdated
Step 1: Forking pycodestyle for editing
---------------------------------------

Fork the pycodestyle repository on github. This will add

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually prefer to spell it GitHub rather than github but that's just me.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, given "GitHub" is it's actual name (as trademarked and branded) that makes sense to me. It's also how I prefer to spell it.

@daspecster

Copy link
Copy Markdown
Contributor Author

Thanks for catching those! Updates pushed.

@sigmavirus24

sigmavirus24 commented Aug 2, 2016

Copy link
Copy Markdown
Member

@daspecster you didn't quite get the capitalization right yet. Capital G and H in GitHub.

GitHub # good
Github # bad

@daspecster
daspecster force-pushed the update-contributing-rst branch from 6ea688d to a090bb2 Compare August 2, 2016 20:28
@daspecster

Copy link
Copy Markdown
Contributor Author

Got it! Thanks!

Squashed the commit as well.

@sigmavirus24
sigmavirus24 merged commit 66e43b4 into PyCQA:master Aug 2, 2016
@sigmavirus24

Copy link
Copy Markdown
Member

Thanks @daspecster! ✨ 🍛 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants