Skip to content

E402: Add "with" statement to allowed keywords - #834

Merged
sigmavirus24 merged 3 commits into
PyCQA:masterfrom
EricCousineau-TRI:issue/833
Sep 25, 2019
Merged

E402: Add "with" statement to allowed keywords#834
sigmavirus24 merged 3 commits into
PyCQA:masterfrom
EricCousineau-TRI:issue/833

Conversation

@EricCousineau-TRI

Copy link
Copy Markdown
Contributor

Resolves #833

@asottile

Copy link
Copy Markdown
Member

Should if be added as well?

@EricCousineau-TRI

Copy link
Copy Markdown
Contributor Author

SGTM. Will file as a separate commit, and split it into a separate PR if it causes issues.

@EricCousineau-TRI

Copy link
Copy Markdown
Contributor Author

Done.

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I assumed you would do another pr - - here is perfect

@EricCousineau-TRI

Copy link
Copy Markdown
Contributor Author

Ah, sorry about that! And thanks!

Comment thread testsuite/E40.py

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread pycodestyle.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E402: Add "with" to allowed_try_keywords

4 participants