Repository navigation
Conversation
RajGahoi
requested review from
angatha,
niccokunzmann and
stevepiercy
as code owners
November 14, 2026 11:18
Contributor
|
Thanks for the pull request, @RajGahoi! A maintainer will review it shortly. |
Contributor
Mixed activityActivity patterns show a mix of organic and automated signals. Evidence
Last 5 PRs: This is an automated analysis by AgentScan |
…yCalendar#2111) Signed-off-by: Raj Gahoi <gahoiraj01@gmail.com>
RajGahoi
force-pushed
the
fix/timezone-duplicate-tzid
branch
from
November 14, 2026 11:22
7e880a4 to
a36558c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Description
When parsing calendars containing duplicate
TZIDlines inside aVTIMEZONEcomponent, theTZIDattribute is parsed into a list of identifiers. Subsequently,cache_timezone_component()passed this list directly toclean_timezone_id(), which invokedtzid.strip("/"), causing an unhandledAttributeError: 'list' object has no attribute 'strip'.This fix:
Timezone.tz_nameproperty to take the firstTZIDif a list is present.TZP.cache_timezone_component, safely extracts the primary identifier iftimezone_component.get("TZID")is a list, and returns early if noTZIDis present.TZP.clean_timezone_id, adds type handling to extract the first string whentzidis passed as a list.test_duplicate_tzid_in_vtimezone_does_not_crashand a towncrier news entry.Checklist