[Ostrava] Lesson 2 - #116
Merged
frenzymadness merged 8 commits intoSep 16, 2021
Merged
Conversation
adelpopelkova
left a comment
adelpopelkova
left a comment
There was a problem hiding this comment.
Looks good! I added a few notes below. For one thing I wasn't able to add a commit suggestion here, so the proposed change is in frenzymadness#8
Co-authored-by: adelpopelkova <59389471+adelpopelkova@users.noreply.github.com>
Co-authored-by: adelpopelkova <59389471+adelpopelkova@users.noreply.github.com>
Author
|
I've fixed also the video links to appear on the session detail page and it still works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text and the video content seem okay to me so I've just copied them from the spring course. I've also changed the very first video link to not start in the last section but to show also how to work with courseware.
Handouts are also correct and should appear when we deploy this to production. The plan is to merge this on Thursday or Friday next week so we can send the links on Friday (@encukou).
@adelpopelkova could you please do a review before you leave?