Basic introspection of #[derive(IntoPyObject)] - #5365
Merged
Merged
Conversation
Struct fields are not supported yet
Tpt
force-pushed
the
tpt/into-py-object
branch
from
August 25, 2025 14:57
27c4f32 to
a30167e
Compare
22 of 32 tasks
davidhewitt
approved these changes
Aug 31, 2025
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Thanks, LGTM. Makes sense to leave structs for a follow up.
Comment on lines
+387
to
+390
| ContainerType::Struct(_) => { | ||
| // TODO: implement using a Protocol? | ||
| builder.push_str("_typeshed.Incomplete") | ||
| } |
Member
There was a problem hiding this comment.
I think for IntoPyObject it's simpler, we can probably declare that we'll always create a dict? Might be able to use a TypedDict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Struct fields are not supported yet
Similar implementation as #5339