Skip to content

Pep8 Python Base Selection Models Update - #7920

Merged
Martin-Molinero merged 2 commits into
QuantConnect:masterfrom
Martin-Molinero:bug-universe-selection-models
Apr 15, 2024
Merged

Pep8 Python Base Selection Models Update#7920
Martin-Molinero merged 2 commits into
QuantConnect:masterfrom
Martin-Molinero:bug-universe-selection-models

Conversation

@Martin-Molinero

Copy link
Copy Markdown
Member

Description

  • Update python base selection models to pep 8, keeping backwards compatibility support

Related Issue

See #7909

Motivation and Context

Base UniverseSelectionModel/FundamentalUniverseSelectionModel/OptionUniverseSelectionModel/FutureUniverseSelectionModel were not backwards compatible with new pep8 naming support.

Runtime Error: Please overrride the 'Select' fundamental function
  at Select
    raise NotImplementedError("Please overrride the 'Select' fundamental function")
 in FundamentalUniverseSelectionModel.py: line 84

in

class UniverseModel(FundamentalUniverseSelectionModel):
    def __init__(self) -> None:
        super().__init__(None)

    def select(self, algorithm, fundamental):
        ...

Requires Documentation Change

N/A

How Has This Been Tested?

Existing tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

- Update python selection models to pep 8, keeping backwards
  compatibility support
@Martin-Molinero
Martin-Molinero force-pushed the bug-universe-selection-models branch from 446aa92 to 5c2015e Compare April 15, 2024 18:05
@Martin-Molinero
Martin-Molinero merged commit 4e39100 into QuantConnect:master Apr 15, 2024
@Martin-Molinero
Martin-Molinero deleted the bug-universe-selection-models branch April 15, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant