Skip to content

refactor: clean tests - #7270

Open
seefs001 wants to merge 2 commits into
QuantumNous:mainfrom
seefs001:refactor/clean-test
Open

seefs001 wants to merge 2 commits into
QuantumNous:mainfrom
seefs001:refactor/clean-test

Conversation

@seefs001

@seefs001 seefs001 commented Sep 9, 2026 •

Copy link
Copy Markdown
Collaborator

⚠️ 提交说明 / PR Notice

English template: .github/PULL_REQUEST_TEMPLATE/en.md

Important

  • 描述可用 AI 辅助。提交前请审阅全文,并声明对其负责,避免未经核对的直接粘贴。
  • 请按本模板填写后再提交。

🔗 关联任务 / Related Issue

  • 新功能请填写下方 Issue 编号;若还没有对应 Issue,请先自行创建。功能讨论请放在 Issue 中进行。

  • 改动较大或方向性变更,请先在关联 Issue 中与维护者达成一致,再提交 PR。

  • Bug 修复请关联对应 Issue。设计取舍、理解偏差或预期不一致,更适合作为讨论或功能请求。

  • Closes #

🚀 变更类型 / Type of change

  • 🐛 Bug 修复 (Bug fix)
  • ✨ 新功能 (New feature)
  • ⚡ 性能优化 / 重构 (Refactor)
  • 📝 文档更新 (Documentation)

📝 变更描述 / Description

(简述做了什么、为什么生效。如果难以简述,建议先拆分范围,或在 Issue 中与维护者对齐。)

清理掉一些冗余的和错误的测试,迁移测试到 vitest 和 testify

📸 运行证明 / Proof of Work

(请写明如何验证:实际步骤与观察结果。UI 变更请附截图或录屏;Bug 修复请说明复现过程与修复后结果。)

✅ 提交前检查项 / Checklist

  • 人工确认: 无论描述是否由 AI 生成,我已审阅全部内容,并声明对其准确性与完整性负责。
  • 非重复提交: 我已搜索现有的 Issues 与 PRs,确认不是重复提交。
  • 新功能关联 Issue: 若此 PR 标记为 New feature,我已关联对应 Issue;若尚无 Issue,我已先自行创建。
  • 事前沟通: 若改动较大或涉及方向性变更,已在关联 Issue 中与维护者沟通并达成一致。
  • 功能范围: 本 PR 不是 Coding Plan、逆向渠道、第三方封装接口,也不是对 Codex 渠道类型的改动。
  • 范围聚焦: 本 PR 为一项聚焦改动,未包含无关代码。
  • 本地验证: 已在本地运行并通过测试或手动验证,维护者可以据此复核。
  • 安全合规: 代码中无敏感凭据,且符合项目代码规范。

Summary by CodeRabbit

  • Tests
    • Modernized backend and frontend assertions for clearer, more consistent failure reporting.
    • Strengthened validation of converter registries, stream handling, pricing, usage logs, model-group layout, configuration, and channel integrations.
    • Added more realistic rendering and asynchronous behavior checks for usage logs and setup guidance.
    • Removed redundant or overlapping tests while preserving coverage of supported behavior.
  • Refactor
    • Simplified test setup, teardown, and shared utility usage across the test suite.
    • Standardized frontend tests on Vitest assertions.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 799b21cf-3fae-436f-b624-3e29892b0113

📥 Commits

Reviewing files that changed from the base of the PR and between 17d7742 and d859179.

📒 Files selected for processing (1)
  • web/src/features/dashboard/components/overview/__tests__/setup-guide.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


Walkthrough

This pull request standardizes Go and web test assertions, removes redundant tests and helpers, updates selected behavioral coverage, and strengthens converter boundary and registry checks.

Changes

Test assertion and coverage modernization

Layer / File(s) Summary
Go test modernization
common/*_test.go, controller/*_test.go, pkg/billingexpr/*_test.go, relay/*_test.go, relaykit/*_test.go, router/*_test.go, service/*_test.go, setting/*_test.go
Go tests use testify assertions. Selected redundant tests and helpers are removed. Billing, relay, converter, settlement, routing, and configuration coverage is updated.
Web test modernization
web/src/**/__tests__/*
Web tests migrate from Node assertions to Vitest matchers, rely on automatic cleanup, validate rendered layout and usage-log fields, and await asynchronous setup-guide rendering.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to d8591

This change stabilizes setup-guide rendering tests without changing product behavior. No current merge-readiness risk remains.

Suggested reviewers: calcium-ion

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 10.19% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 216 functions across 34 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title relates to the test refactoring, but "clean tests" is too broad to identify the main changes, which include assertion migrations, redundant test removal, and a setup-guide timing fix. Use a specific title such as "refactor: migrate and streamline test assertions" or mention the setup-guide timing fix if that is the primary change.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each test with care
And trims old helpers from the lair
New matchers hop in line
While cached traces stay aligned
Clean assertions bloom everywhere

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant