Repository navigation
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. Walkthrough
ChangesStream outcome classification
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Only normally completed, error-free streams remain eligible for health sampling after cancellation; incomplete and errored canceled requests remain excluded. No actionable merge risk remains in the reviewed scope. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the stream at dawn Comment |
Sync 54 upstream commit(s) via merge (fork history preserved). Behavior changes from upstream: - 4013729 fix: disable sensitive word filtering by default and clear the default word list (QuantumNous#7814) Upstream commits: - 5e95951 feat(channels): add drag mode for channel priority ordering - 5a59d69 fix(pricing): hide task prices left at zero when another price is set - 3e2ce2c fix: align model card summary with status bar hours (QuantumNous#7847) - b0a98ac fix(web): apply theme class before first paint so Dark Reader detects dark mode (QuantumNous#7571) - f92c576 fix(web): cover Cloudflare clef and NVIDIA model families in provider rules (QuantumNous#7840) - ff36846 fix(relayconvert): 保留 Chat/Claude → Responses 转换中 input_image 的 detail 字段 (QuantumNous#7855) - 09109ec fix(middleware): 过载哨兵改用容器口径并加入连续性与新鲜度判定 (QuantumNous#7317) - d032204 feat(aws): add Mantle Messages API support - ca2cae6 fix(relaykit): emit summary on reasoning items announced without one (QuantumNous#7833) - 45fbb14 fix(rate-limit): count each group with its own limit separately - 6549a17 fix(dashboard): draw flow chart labels in the theme text color (QuantumNous#7821) - c9179d3 fix(playground): support the reasoning field in chat responses (QuantumNous#7831) - 908f94d fix(web): hide pages the user cannot open from console search - 19d435e fix(relay): mask only the custom upstream address in error messages (QuantumNous#7822) - 718a4e7 fix(vertex): use the multi-region hostnames for us and eu - f196934 feat(plugins): bind Hailuo, Vidu and Veo plugins to New API channels - bfdad29 fix(vidu): bill the model, duration and resolution Vidu generates - 150ab3c chore(licenses): refresh the third-party dependency inventory - 76cd511 build: upgrade moejs to v0.1.0-alpha.7 - 1b63c28 fix(claude): preserve explicit zero usage and cache-only billing (QuantumNous#7816) - c9f7b62 fix(web): sort pricing models by input, output and per-request price (QuantumNous#7813) - a0bf6a8 fix(vertex): pass project_id in API Key mode to avoid 404 on official endpoints (QuantumNous#6330) - 4013729 fix: disable sensitive word filtering by default and clear the default word list (QuantumNous#7814) - 7de10f2 feat(token): let an API key read its owner's quota - ef60ef2 fix(relay): keep the cause of a failed body read for every later reader - d10eafb fix(relay): report the real cause when a request body cannot be read - 63cecab feat(channel): support Sub2API balance queries (QuantumNous#7749) - b4be2a7 feat(ui): show newly added pricing groups at the top (QuantumNous#7782) - 633b4c5 feat(logs): export usage logs from the common log page (QuantumNous#7774) - dd59854 chore(deps-dev): bump undici from 6.28.0 to 6.29.0 in /electron (QuantumNous#7624) - 93cf4ba chore(deps-dev): bump js-yaml from 4.3.1 to 4.3.2 in /electron (QuantumNous#7327) - 3c9fb2a chore(deps-dev): bump brace-expansion from 1.1.16 to 1.1.21 in /electron (QuantumNous#7623) - 9f04810 chore(deps): bump ai from 7.0.31 to 7.0.136 in /web (QuantumNous#7767) - 3fe394c chore(deps): bump github.com/gorilla/websocket from 1.5.0 to 1.5.3 (QuantumNous#7001) - 1c58f3d chore(deps-dev): bump fast-uri from 3.1.5 to 3.1.7 in /electron (QuantumNous#7169) - 7f51a97 chore(deps-dev): bump js-yaml from 4.3.1 to 4.3.2 in /electron (QuantumNous#7327) - 7e25797 chore(deps-dev): bump electron from 39.8.10 to 41.10.6 in /electron (QuantumNous#7625) - bf4e1eb build(deps-dev): bump oxfmt from 0.57.0 to 0.72.0 in /web (QuantumNous#7766) - 82306b3 build(deps-dev): bump @tanstack/router-plugin in /web (QuantumNous#7768) - c730add build(deps): bump stream-markdown-parser from 1.1.3 to 1.2.18 in /web (QuantumNous#7769) - b8c2dc1 build(deps): bump yace from 1.1.0 to 1.1.1 in /web (QuantumNous#7770) - ba29f06 chore(deps-dev): bump @xmldom/xmldom from 0.8.13 to 0.8.15 in /electron (QuantumNous#7187) - 767a82b fix(claude): forward thinking.block_binding and every anthropic-beta value (QuantumNous#7732) - 2b85a8f fix(auth): show legal consent warning on password login (QuantumNous#7771) - 2ed0587 fix(ci): stabilize checks and configure Bun dependency updates (QuantumNous#7765) - 9948b1e fix(pricing): accept declared endpoint arrays in pricing conversion (QuantumNous#7724) - 4bfcf28 chore(web): bump @lobehub/icons to 5.22.0 (QuantumNous#7764) - fc08b76 fix(web): preserve recorded billing tiers in usage log previews (QuantumNous#7763) - ba0e478 fix(relaykit): preserve assistant text with tool calls (QuantumNous#6871) - 34b1942 fix(pricing): allow root access when the model square is disabled (QuantumNous#7761) - b22a43b fix: mark task settlement logs with is_task for tiered billing display (QuantumNous#7446) - bbf60b4 fix(logs): vertically align billing source icons on mobile (QuantumNous#7760) - 3f926c3 fix(metrics): count completed streams after context cancellation (QuantumNous#7638) - 3827fd8 fix(web): show cache read price on expression model cards (QuantumNous#7757) Local tests not run (CI-only).
Select nine upstream fixes from QuantumNous/new-api main at 49271d2. Preserve OIDC, root-managed integration clients, bounded diagnostics, canonical mem-ai routes, and existing dependencies. Do not include pricing, schema, frontend, or deployment changes. Keep the AWS safeguards regression without importing unrelated thinking-binding tests from three-way context. Add canceled-context stream coverage alongside the upstream non-stream regression. Upstream sources: bc795cc fix:修复stop为非字符串和[]string的协议转换问题 (QuantumNous#7935) 4d962e4 fix(relaykit): preserve tool argument numbers in Claude responses (QuantumNous#7996) 0165fef fix(relaykit): preserve Gemini text alongside tool calls (QuantumNous#7998) 34003e9 test: stabilize channel affinity cache keys (QuantumNous#8009) 01da3a5 perf(relay): stop recompiling param override regexes on every request (QuantumNous#8061) ad56112 fix(relay): apply GPT-6 chat parameter rules to gpt-6.1-sol and gpt-6.1-terra (QuantumNous#8064) 3f926c3 fix(metrics): count completed streams after context cancellation (QuantumNous#7638) 5478811 fix: count completed non-stream relays after context cancellation (QuantumNous#7844) 49271d2 fix(aws): preserve safeguards in Bedrock Invoke requests (QuantumNous#8071) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Agent
Links
a5b40663d3307fc5011c85b83eb18bbaa33dbad2(committer 时间:2026-09-18 03:24:30 UTC)。User request
Out of scope — refuse
Open gate — do not open unless all are satisfied
go buildor tests passed: yes;EOF/DONE 取消后的分类由 ignored 变为 success,其他边界结果保持不变。Kind
Issue facts
1a4166d8e上,仅改变 context 状态即可得到 success → ignored。Change
仅修改
pkg/perf_metrics/outcome.go:先读取已有流终态,再判断 context 取消。只有同时满足下列条件,才允许已取消 context 的请求继续参与原有分类:
IsStream为 true,StreamStatus 存在;completed,结束原因为eof或done;没有提前返回 success;其他分类分支保持原样。生成过程中取消、未完成或存在错误的请求不因该例外而误计成功。
本代码由 AI 辅助完成,已对照实际 diff 和可执行复现审阅验证;提交者不是仓库历史核心开发者。
Research
Duplicate / prior art
repo:QuantumNous/new-api created:>=2026-09-18下搜索"ClassifyRelayOutcome"、"perf_metrics"、"metrics" "cancel"、"completed" "ignored"、"健康";推送前另查is:pr "7637"、is:pr "ClassifyRelayOutcome"、is:pr "completed" "cancel"。Docs and code
Alternatives considered
Files
pkg/perf_metrics/outcome.goBehavior
Verification
从项目根目录运行 [Bug] 已正常完成的流式请求因 context 取消被模型健康统计忽略 #7637 的仓库外独立复现程序;原版 outcome.go 使用 Go overlay 加载。实际对照:
go run -p 1 <仓库外的 verify.go>:16 项确定性边界校验通过;正常 EOF/DONE 在取消后计成功,中途取消、缺终态、异常结束、流错误、API 错误、业务拒绝、非流式取消及 nil 状态不错误地计成功。go test -p 1 -parallel 1 ./pkg/perf_metrics ./relay/common ./relay -count=1 -timeout=2m:三个包通过。go test -p 1 -parallel 1 ./controller -run '^TestResponses(InterruptedStreamHealth|HTTPHealthCountsFinalResult|WebSocketPreRoutingRejectionsFollowHealthClassification)$' -count=1 -timeout=2m:通过;覆盖 HTTP/WS 超时、中途取消、业务拒绝、重试最终结果及路由前拒绝的健康分类。go vet -p 1 ./pkg/perf_metrics、go build -p 1 ./...:通过。git diff --check upstream/main...HEAD:通过;GitNexusdetect-changes --scope compare --base-ref upstream/main仅定位到 ClassifyRelayOutcome,风险 low。Risks
Scope check
Summary by CodeRabbit