Repository navigation
fix(relay): allow Azure channels to opt in to Responses WebSocket (#8047) - #8075
Merged
seefs001 merged 1 commit intoOct 28, 2026
Merged
Conversation
…antumNous#8047) Azure channels with responses_websocket_enabled were rejected by FilterResponsesWebSocket, and the channel form hid the toggle for type 3. The OpenAI adaptor already builds the Azure /openai/v1/responses URL with api-version and sets the api-key header, and DoWssRequest reuses both, so no relay URL change is needed.
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kyuhwi-choi
pushed a commit
to attodev/new-api
that referenced
this pull request
Oct 30, 2026
…antumNous#8047) (QuantumNous#8075) Azure channels with responses_websocket_enabled were rejected by FilterResponsesWebSocket, and the channel form hid the toggle for type 3. The OpenAI adaptor already builds the Azure /openai/v1/responses URL with api-version and sets the api-key header, and DoWssRequest reuses both, so no relay URL change is needed. (cherry picked from commit 26c488c)
1 of 4 tasks
woncc
added a commit
to 86669666/new-api
that referenced
this pull request
Nov 5, 2026
…antumNous#8047) (QuantumNous#8075) (#147) Azure channels with responses_websocket_enabled were rejected by FilterResponsesWebSocket, and the channel form hid the toggle for type 3. The OpenAI adaptor already builds the Azure /openai/v1/responses URL with api-version and sets the api-key header, and DoWssRequest reuses both, so no relay URL change is needed. (cherry picked from commit 26c488c) Co-authored-by: Seefs <40468931+seefs001@users.noreply.github.com>
shirosoralumie648
added a commit
to shirosoralumie648/newapi-rev
that referenced
this pull request
Nov 5, 2026
Sync 75 upstream commit(s) via merge (fork history preserved). Upstream commits: - 7061447 fix(auth): 校验 Redis 鉴权缓存完整性 (QuantumNous#8200) - ba5f736 fix(gemini): bill embeddings from upstream usageMetadata (QuantumNous#8182) - 94b5216 feat(vertex): add per-channel v1beta1 endpoint switch (QuantumNous#8179) - 83b18fe feat(channel): return created IDs with input mappings (QuantumNous#8164) - 52c1730 feat(gemini): add Argon fields and reasoning mappings (QuantumNous#8177) - 9b473a3 fix(twofa): restart the failure count after a lockout expires (QuantumNous#8172) - 45746ee feat(relay): add opt-in HTTP/2 health checks (QuantumNous#8059) - c046559 feat(plugins): bill gemini omni by the tokens vertex reports (QuantumNous#8153) - 651d5a2 fix(xai): preserve token details in stream usage conversion (QuantumNous#6420) - 70e6af6 perf: read and edit request JSON and base64 with moego (QuantumNous#8148) - d0abbf6 feat(plugins): generate video with Gemini Omni on Vertex AI channels (QuantumNous#8142) - ea343c4 fix(plugins): charge relayed streams even when the reserve or task insert fails (QuantumNous#8121) - fe57cba fix(plugins): prefer Kling's returned price (list_price) for Kling 4.0 cash billing (QuantumNous#8125) - 1424ffd fix(plugins): load plugins that declare their own /{key} address (QuantumNous#8119) - 8b253de fix(plugins): keep Kling 4.0 durations in range and map every video size (QuantumNous#8118) - c59f6fd feat(plugins): serve task plugins at the vendors' own paths and answer as the vendors do (QuantumNous#8117) - 37d23dc fix(profile): honor global sidebar visibility (QuantumNous#7429) - 7743627 fix(deps): upgrade DOMPurify to 3.4.17 (QuantumNous#8116) - 883eeb8 feat(plugins): warn about task models a plugin cannot charge - 1e8c707 chore(deps): bump @codemirror/language from 6.12.4 to 6.13.1 in /web (QuantumNous#8102) - 6e78cb3 chore(deps): bump marked from 18.0.6 to 18.1.2 in /web (QuantumNous#8103) - 9fc70bb chore(deps-dev): bump @tanstack/react-query-devtools in /web (QuantumNous#8104) - cef7820 chore(deps-dev): bump knip from 6.27.0 to 6.43.0 in /web (QuantumNous#8105) - 1695171 chore(deps): bump tailwind-merge from 3.6.0 to 3.7.0 in /web (QuantumNous#8106) - 7fa815e chore(deps-dev): bump fast-uri from 3.1.7 to 3.1.9 in /electron (QuantumNous#8007) - ee0f0ac chore(deps-dev): bump electron from 41.10.6 to 42.11.16 in /electron (QuantumNous#8008) - 837b814 chore(deps): bump undici in /electron (QuantumNous#8006) - 3150dfe chore(deps): bump github.com/go-jose/go-jose/v4 from 4.1.4 to 4.1.6 (QuantumNous#8112) - a3851c2 fix: save Turnstile keys before enabling (QuantumNous#7960) - 4193734 fix(logger): keep gin access and recovery logs on the current log file after rotation (QuantumNous#8098) - f366017 Merge commit from fork - 829f082 fix: unmount authenticated layout on sign-out to stop credential-less refetches (QuantumNous#8110) - 9eda50a Merge commit from fork - a2defd2 Merge commit from fork - e449cc7 feat: sample immediate task successes in model performance metrics (QuantumNous#8067) - fcc241c fix: start affinity fallback at the highest channel priority (QuantumNous#8078) - b08ee86 fix(cloudflare): preserve embedding response data (QuantumNous#8041) - 26c488c fix(relay): allow Azure channels to opt in to Responses WebSocket (QuantumNous#8047) (QuantumNous#8075) - 55515db fix(relay): terminate streams on exact bare done markers (QuantumNous#8074) - 49271d2 fix(aws): preserve safeguards in Bedrock Invoke requests (QuantumNous#8071) - 5478811 fix: count completed non-stream relays after context cancellation (QuantumNous#7844) - ad56112 fix(relay): apply GPT-6 chat parameter rules to gpt-6.1-sol and gpt-6.1-terra (QuantumNous#8064) - 01da3a5 perf(relay): stop recompiling param override regexes on every request (QuantumNous#8061) - 34003e9 test: stabilize channel affinity cache keys (QuantumNous#8009) - 0165fef fix(relaykit): preserve Gemini text alongside tool calls (QuantumNous#7998) - 4d962e4 fix(relaykit): preserve tool argument numbers in Claude responses (QuantumNous#7996) - f1569d1 fix(pricing): classify dynamic per-request billing correctly (QuantumNous#8010) - bc795cc fix:修复stop为非字符串和[]string的协议转换问题 (QuantumNous#7935) - 9823ebc fix(billing): bill cache_creation_input_tokens reported in prompt_tokens_details (QuantumNous#7909) - e835b1b chore(deps): bump axios from 1.18.1 to 1.20.0 in /web (QuantumNous#7835) - 5c8032d chore(deps): bump react-i18next from 17.0.10 to 17.1.0 in /web (QuantumNous#7981) - 0b667ca chore(deps): bump i18next from 26.3.6 to 26.5.3 in /web (QuantumNous#7979) - 4105bd0 chore(deps): bump input-otp from 1.4.2 to 1.5.0 in /web (QuantumNous#7980) - b6b85ca chore(deps): bump react-resizable-panels from 4.12.2 to 4.14.6 in /web (QuantumNous#7982) - 1dafb19 fix(gemini): preserve top-level imageConfig in chat conversion - 0034b24 fix(task): wait up to 72 hours before timing out tasks - a404460 chore(web): upgrade Bun to 1.4.4 and use bun check - 33c61a2 fix: prevent stale values when switching edit drawer records (QuantumNous#7989) - 30748c6 fix(logging): 隐藏访问日志中的查询凭据 (QuantumNous#7972) - 7fb6e57 fix(channels): preserve advanced custom body passthrough settings (QuantumNous#7971) - e9d4d63 feat(billing): bill OpenAI 12-hour prompt cache writes at their own price (QuantumNous#7965) - d0b840e fix(relay): keep the client's JSON Schema property order - d8e6561 feat(web): copy model names from usage log details - 8802113 feat(task): let ordinary channels compete on shared plugin endpoints - eb169e7 feat(pricing): adjust synced upstream prices by the site exchange rate - e2321a5 chore(web): sort locale keys - db80ac8 fix(task): let task plugins validate their own requests - dbe97be feat(task): pass client request headers to task plugin drivers - 556517f feat(task): accept multipart bodies on native plugin routes - 94cc3ff fix(billing): bill Claude cache writes that arrive without a 5m/1h split - 7e65967 fix(relay): stop cutting off slow clients during large stream events - 0c2af97 fix(relay): finish delivered Responses streams without false disconnect errors (QuantumNous#7956) - 7d8b912 fix: upgrade Go to 1.26.10 for CVE-2026-111943 (QuantumNous#7942) - 4d36f2c chore(deps-dev): bump vitest from 4.1.10 to 5.0.4 in /web (QuantumNous#7838) - eea05e0 chore(deps): bump github.com/klauspost/compress from 1.18.3 to 1.18.7 (QuantumNous#7931) Local tests not run (CI-only).
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent
Links
User request
Out of scope — refuse
Open gate — do not open unless all are satisfied
go buildor tests passed: yesKind
Issue facts
GET /v1/responses(WebSocket) upgrades with 101, then the firstresponse.createreturns503 model_not_foundwhen the model is served only by an Azure channel (type 3)./v1/responsesby default (OpenCode 2.0 in the report) cannot fall back to HTTP POST after the 101 upgrade.response.createsent directly towss://<resource>.openai.azure.com/openai/v1/responses?api-version=...returnsresponse.created. In new-api,channelMatchesFilterforFilterResponsesWebSocketreturns false for type 3, and the channel form hides the toggle for type 3.GET /v1/responses(WebSocket), channel type Azure (3), native Responses WebSocket, pass-through disabled. Frontend: channel formresponses_websocket_enabledtoggle. Billing and deployment: not applicable.Change
model/channel_constraint.go: addChannelTypeAzureto theFilterResponsesWebSocketallow list. TheResponsesWebSocketEnabledcheck before the type switch is unchanged, so Azure still needs the per-channel opt-in.web/src/features/channels/lib/responses-websocket.ts: add type 3 toRESPONSES_WEBSOCKET_CHANNEL_TYPESso the form shows and saves the toggle for Azure.openResponsesWSUpstream, which does not exist onmain. The WebSocket session dials throughrelaychannel.DoWssRequest, which calls the adaptor'sGetRequestURLandSetupRequestHeaderand mapshttpstowss. Azure resolves to the OpenAI adaptor, whoseRelayModeResponsesbranch already builds/openai/v1/responses?api-version=<preview | AzureResponsesVersion>(or/openai/responses?api-version=<channel api version>forcognitiveservices.azure.com) and setsapi-keywithoutAuthorization. The WebSocket path therefore reuses the Azure HTTP Responses URL and auth.Research
Duplicate / prior art
gh pr list -R QuantumNous/new-api --state all --search "azure responses websocket",gh issue list -R QuantumNous/new-api --state all --search "azure websocket responses"Docs and code
responses_websocket_enabled.relay/responses_websocket.gorunCall→selectResponsesWSChannel(addsFilterResponsesWebSocket) →relaychannel.DoWssRequest(relay/channel/api_request.go) →openai.Adaptor.GetRequestURL/SetupRequestHeader(relay/channel/openai/adaptor.go).middleware.SetupContextForSelectedChannelsetsapi_versionfromchannel.Otherfor Azure, whichGenRelayInforeads intoApiVersion.restoreConnectionContextrechecksResponsesWebSocketEnabledon every laterresponse.create.Alternatives considered
response.createto upstream HTTP SSE (issue alternative 2). This is a larger, directional change.Files
model/channel_constraint.goFilterResponsesWebSocketweb/src/features/channels/lib/responses-websocket.tsrelay/responses_websocket_test.goapi-version/api-keytestweb/src/features/channels/components/__tests__/responses-websocket-setting.test.tsxBehavior
/v1/responsesWebSocket, and the form had no toggle for them.responses_websocket_enabled: trueis selectable and dialswss://<base>/openai/v1/responses?api-version=...withapi-key. With the option off (the default), WebSocket selection still skips it. HTTP POST/v1/responsesis unchanged.Verification
git stash push -- model/channel_constraint.go && go test ./relay/ -run TestSelectResponsesWSChannelAcceptsNativeResponsesChannelTypes -count=1→--- FAIL: .../azure. Aftergit stash pop, the same test plusTestResponsesWSAzureDial→ok github.com/QuantumNous/new-api/relay.go test ./relay/ -run 'TestResponsesWSAzureDial|TestSelectResponsesWSChannelAcceptsNativeResponsesChannelTypes|TestResponsesWSChannelRoutingRequiresExplicitOptIn' -count=1 -v→ all subtests PASS:openai_v1_default_preview,channel_responses_version,cognitiveservices_uses_channel_api_version, and the selection subtests includingazure.go build ./... && go vet ./relay/ ./model/ && go test ./relay/ ./model/ ./relay/channel/openai/ ./relay/channel/ -count=1→okfor all four packages.responses-websocket.tsstashed,bunx vitest run src/features/channels/components/__tests__/responses-websocket-setting.test.tsx→Tests 2 failed | 25 passed (27)(the type 3 cases). After restoring →Tests 27 passed (27).bunx tsc -b→ exit 0.bunx oxlint -c .oxlintrc.json <2 changed web files>→ exit 0.bunx oxfmt -c .oxfmtrc.json --check <2 changed web files>→All matched files use the correct format.gofmt -l <2 changed Go files>→ no output.Enable Responses WebSocket, and saves it on and off.TestResponsesWSAzureDialUsesAzureResponsesURLAndAPIKeydials a localhttptestWebSocket server throughDoWssRequestwith an AzureRelayInfoand asserts the handshake path,api-version,api-key, and noAuthorization. Anazurecase was added to the existing selection table, and type 3 was added to the frontend supported types table. The existingTestResponsesWSChannelRoutingRequiresExplicitOptIncovers the off case, because the opt-in check runs before the type switch.relaytests (no schema change); macOS, Go pergo.mod, Bun 1.4.2.wss://session to Azure OpenAI / Foundry (no Azure resource or key available locally). Azure's server-side WebSocket behavior, its event shapes, and acceptedapi-versionvalues come from the issue report, not from a test here.Risks
api-version, the dial fails and goes through the existing retry and channel error handling. This only happens for channels where the operator enabled the option.Scope check