You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds first-class XLSX export capability to the exporter by introducing a new XlsxEngine that writes a minimal Office Open XML workbook as a streamed ZIP archive, plus integration coverage and CI/dev dependencies to support ZIP-based validation.
Changes:
Introduce XlsxEngine to generate a minimal .xlsx (OOXML) archive via ZipStream.
Add an integration test that validates the produced ZIP entries and key XML values (workbook, sheets, core properties).
Update docs and CI/dev requirements to include XLSX support and ZIP tooling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File
Description
test/Integration/XlsxTest.php
New integration test that validates XLSX ZIP contents and XML structure/values.
src/Engines/XlsxEngine.php
New streaming OOXML XLSX writer using ZipStream, with minimal worksheet/style/core-props support.
README.md
Document XLSX as a supported format and add XlsxEngine API docs.
composer.json
Add ext-zip to dev requirements (used by integration test validation).
.mddoc.xml.dist
Update supported formats list to include XLSX.
.github/workflows/ci.yml
Ensure CI installs the zip extension to run XLSX-related tests.
Use OPC namespace for core-properties relationship
src/Engines/XlsxEngine.php:292
The core-properties relationship type uses the office-document namespace, but this relationship is defined by OPC under http://schemas.openxmlformats.org/package/2006/relationships/metadata/core-properties. Package-aware consumers may therefore fail to discover docProps/core.xml; use the package relationships namespace here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation