Add TheRock model for validation - #53
Merged
Merged
Conversation
danpetreamd
previously approved these changes
Oct 22, 2025
danpetreamd
left a comment
danpetreamd
left a comment
There was a problem hiding this comment.
LGTM.
FYI - while having multiple RUN commands is esthetically far more pleasing, for image size minimization it is better to merge all the RUN commands together. I wish Docker came up with a layer optimization feature so that we can get both the nice layout of your Dockerfile and minimal image size.
Rohan138
reviewed
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add TheRock model for validation
Technical Details
Test Plan
Test Result
Submission Checklist